Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Profile created by settings unchecked (thus Settings using default profile) doesn't respect setting items which is described with "Applies to all profiles" #189798

Closed
wrlssqi opened this issue Aug 7, 2023 · 10 comments · Fixed by #191090
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders user-profiles User profile management verified Verification succeeded
Milestone

Comments

@wrlssqi
Copy link

wrlssqi commented Aug 7, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.82.0-insider
    Commit: 1606401
    Date: 2023-08-07T05:34:01.211Z
    Electron: 22.3.18
    ElectronBuildId: 22689846
    Chromium: 108.0.5359.215
    Node.js: 16.17.1
    V8: 10.8.168.25-electron.0
    OS: Linux x64 5.15.0-78-generic
  • OS version: ubuntu 22.04.3 LTS

Steps to Reproduce:

  1. change "Title Bar Style" settings of default profile to "custom"

  2. create a new profile, and uncheck settings(means using default profile settings).
    image

  3. when click creat button, a pop up windows says "a settings has changed that requires a restart to take effect vscode"
    image

  4. click restart, and check "Title Bar Style" settings, find it is native ,and can't be changed.

  5. every time switch profiles between default and other created profiled will popup the annoying "a settings has changed that requires a restart to take effect vscode" window, and only the default profile shows the custom title bar.

@wrlssqi
Copy link
Author

wrlssqi commented Aug 7, 2023

i start use user profile since 1.81.0, and i don't know if such bug also appears on early version. besides, vscode don't have this bug when on windows 11.

@wrlssqi
Copy link
Author

wrlssqi commented Aug 7, 2023

actually this bug is very annoying ,because, when switch to user profile whose "Title Bar Style" settings is forced to native, it has no menu bar at all! user can't do many operation throuth menu bar, because it is not there at all. every thing is right when in default profile.

image

@wrlssqi
Copy link
Author

wrlssqi commented Aug 7, 2023

it seems that windows 11 also has this problems. but the default "Title Bar Style" settings on windows is "custom",so it appears normally when switch between profiles (default profile "Title Bar Style" setting is custom ).
i also find that when in user profile, change "Title Bar Style" settings in UI dose change settings.json contents, but it just don't influence the user profile currently on , it only influence default profile.

@wrlssqi
Copy link
Author

wrlssqi commented Aug 7, 2023

a guess is that when a profile is created with settings unchecked(use default profile settings), all settings with description " Applies to all profiles" will be forced to default value when the profile is switched on.

image

@wrlssqi
Copy link
Author

wrlssqi commented Aug 8, 2023

it seems that this issue #189725 is the same bug with me

@wrlssqi wrlssqi changed the title new created user profile's "Title Bar Style" settings is forced to native and can't be changed Partial Profile created by settings unchecked (thus Settings using default profile) doesn't respect setting items which is described with "Applies to all profiles" Aug 11, 2023
@memchr
Copy link

memchr commented Aug 14, 2023

I suggest toggling [ ] Settings and using symlink as a workaround for now.

ln -srf ~/.config/Code/User/settings.json ~/.config/Code/User/profiles/$(jq --arg v <profile_name> -r '.userDataProfiles | .[] | select(.name==$v) | .location '  ~/.config/Code/User/globalStorage/storage.json)/settings.json
  • note: <profile_name> is a placeholder, replace with appropriate value

image

@br14n-sol
Copy link

br14n-sol commented Aug 18, 2023

I think I have the same problem or at least it's similar, it just happens the other way around... By default, I have the menu bar hidden, but when I create other profiles, the bar becomes visible. 🤔

@br14n-sol
Copy link

Default profile
image

Other profile
image

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug user-profiles User profile management labels Aug 23, 2023
@sandy081 sandy081 added this to the August 2023 milestone Aug 23, 2023
@sandy081
Copy link
Member

To verify:

  • Open window with default profile
  • Change update.mode setting to non default value
  • Restart application
  • Create a profile that uses settings from default profile
  • Make sure the application is not asked to restart
  • Make sure the value of update.mode setting is set to the value that was set before.

sandy081 added a commit that referenced this issue Aug 23, 2023
@wrlssqi
Copy link
Author

wrlssqi commented Aug 24, 2023

To verify:

  • Open window with default profile
  • Change update.mode setting to non default value
  • Restart application
  • Create a profile that uses settings from default profile
  • Make sure the application is not asked to restart
  • Make sure the value of update.mode setting is set to the value that was set before.

yeah,I follow your steps, change default profile update.mode to "manual", and when create a new profile that uses settings from default profile, vscode does ask to restart! and even worse is after restart, vscode is still in default profile, can't be changed to other profile. It seems that update.mode settings prohibits vscode swithing to created user profile.
All tested on windows version , with vscode version 1.81.1

sandy081 added a commit that referenced this issue Aug 24, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders user-profiles User profile management verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants