Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GNU style file:line.column links #190350

Closed
Timmmm opened this issue Aug 13, 2023 · 2 comments · Fixed by #190351 or #191602
Closed

Support GNU style file:line.column links #190350

Timmmm opened this issue Aug 13, 2023 · 2 comments · Fixed by #190351 or #191602
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@Timmmm
Copy link
Contributor

Timmmm commented Aug 13, 2023

The Sail compiler outputs file:line links that follow this GNU convention:

Warning: Redundant case sail-riscv/model/riscv_sys_control.sail:206.6-7:
206 |      _ => false
    |      ^

This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode.

See rems-project/sail#287
@Timmmm Timmmm mentioned this issue Aug 13, 2023
Merged
@Tyriar Tyriar assigned Tyriar and unassigned bhavyaus Aug 13, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-links labels Aug 13, 2023
@Tyriar Tyriar added this to the August 2023 milestone Aug 13, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 14, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2023
@jrieken
Copy link
Member

jrieken commented Aug 29, 2023

Doesn't seem to work, see echo src/vs/workbench/contrib/snippets/browser/snippetsFile.ts:70.30-36

Screenshot 2023-08-29 at 14 41 05

@jrieken jrieken reopened this Aug 29, 2023
@jrieken jrieken added the verification-found Issue verification failed label Aug 29, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Aug 29, 2023
@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

The PR intentionally left that out:

so I've opted for the simpler option of just ignoring the - part.

But it should be easy to add so will leave this open.

@Tyriar Tyriar mentioned this issue Aug 29, 2023
Merged
Tyriar added a commit that referenced this issue Aug 29, 2023
@Tyriar
Add GNU style link 'r-c.ce', 'r.c-re.ce'
fdb265d 
See https://www.gnu.org/prep/standards/html_node/Errors.html

sourcefile:line1.column1-line2.column2: message
sourcefile:line1.column1-column2: message
sourcefile:line1-line2: message

Fixes #190350
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2023
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
5 participants
@Timmmm @jrieken @Tyriar @bhavyaus @VSCodeTriageBot