Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing accessibility help message in an editor #191672

Closed
joyceerhl opened this issue Aug 29, 2023 · 16 comments · Fixed by #191720
Closed

Confusing accessibility help message in an editor #191672

joyceerhl opened this issue Aug 29, 2023 · 16 comments · Fixed by #191720
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

  1. Open settings.json
  2. Run Open Accessibility Help
  3. See this message
  4. I don't really understand what "Disable the aria hint label to open this" means

Image

@meganrogge
Copy link
Contributor

Yeah, I've wondered about this wording. It means disable the aria hint that told you to open this (the accessible view). Perhaps replacing "this" with "the accessible view" would be better?

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues polish Cleanup and polish issue labels Aug 29, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 29, 2023
@joyceerhl
Copy link
Contributor Author

Oh, do you mean that you would user Alt+F6 to disable the aria hint? Maybe it could say that?

meganrogge added a commit that referenced this issue Aug 29, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2023
@aiday-mar
Copy link
Contributor

aiday-mar commented Aug 30, 2023

Hi, not sure if I am incorrectly verifying. I do not see any text relating to the aria-hint in my accessible help view?

Screenshot 2023-08-30 at 11 02 06

@aiday-mar aiday-mar added the verification-found Issue verification failed label Aug 30, 2023
@meganrogge
Copy link
Contributor

the hint only exists for features which have a corresponding accessibility.verbosity setting. For example, copilot inline/panel chat. @aiday-mar

@meganrogge meganrogge removed the verification-found Issue verification failed label Aug 30, 2023
@meganrogge
Copy link
Contributor

meganrogge commented Aug 30, 2023

In fact, it was a different bug that Joyce was seeing this when she invoked the help dialog in the editor. That was fixed as well. #191722

@joyceerhl joyceerhl added the verified Verification succeeded label Aug 31, 2023
@joyceerhl
Copy link
Contributor Author

Text is better now but imo could still be improved

image

I'd expect "Toggle the accessibility help for this feature using Alt+F6"

@meganrogge
Copy link
Contributor

It's not a toggle, rather a one-way action by design as users will almost never want to enable a hint they're familiar with.

@joyceerhl
Copy link
Contributor Author

Right, so "Disable the accessibility help for this feature using Alt+F6"

@meganrogge
Copy link
Contributor

Accessibility help and verbosity are different things.

@joyceerhl
Copy link
Contributor Author

My bad, "Disable the accessibility verbosity for this feature using Alt+F6"

The point is that the current text doesn't make clear the connection between the parenthesized text and the directive preceding it

@meganrogge
Copy link
Contributor

Oh, for screen reader users, including the keybinding in parenthesis is expected and a recommended practice. It reduces verbosity.

@joyceerhl
Copy link
Contributor Author

Then should the preceding sentences in the accessibility help for the chat response follow that pattern, instead of "To do __, invoke the __ command"?

@meganrogge
Copy link
Contributor

I thought that would be wordy/redundant:

To disable verbosity for this feature, invoke the command Disable Accessibility Verbosity (alt+f6).

Also, unlike the others, this command doesn't appear in the command palette, so it's not important to indicate the command title here IMO.

@meganrogge
Copy link
Contributor

It is aligning with the accessible view specific actions like "exit this dialog via the escape key". the spacing there currently looks wrong though (no space, not on its own line)

@meganrogge
Copy link
Contributor

I could also tweak that like so for more consistency Exit this dialog (Escape).

@meganrogge
Copy link
Contributor

I see your point though. We should improve the consistency here and also probably lessen the redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants