Invoking choice from Show CodeLens Commands For Current Line may require multiple Enters or clicks

[gjsjohnmurray]

Type: Bug

1. Set "typescript.referencesCodeLens.enabled": true
2. Open a .ts file.
3. Put cursor on a line that has an N references CodeLens above it.
4. Open Command Palette and run Show CodeLens Commands For Current Line.
5. Press Enter to try and run the selected (only) entry (N references).

🐛 nothing happens until you press Enter a second time (or more...).

Results of using a mouse-click to try and run the CodeLens from the quickpick is the same. First click does nothing, and a second click is required.

This also happens in 1.81.1 so it is not a 1.82 regression.

VS Code version: Code - Insiders 1.82.0-insider (e7756c8, 2023-08-31T05:33:59.698Z)
OS version: Windows_NT x64 10.0.22621
Modes:

[gjsjohnmurray]

Seems to be caused by this code that arrived in b5d3ec5 when @jrieken was fixing #139910

vscode/src/vs/editor/contrib/codelens/browser/codelensController.ts

Lines 508 to 511 in 414606b

	if (model.isDisposed) {
	// retry whenever the model has been disposed
	return await commandService.executeCommand(this.id);
	}

[jrieken]

I can reproduce. The code lens model is disposed because the focus lost/gain cycle retriggers its computation and then the picker restarts (to make sure a fresh item is selected)...

[gjsjohnmurray]

/verified

[andreamah]

Added verified tag, as this was author-verified