No copy path for (non-workspace) file

[jrieken]

• opened a log file
• missing reveal in finder
• missing copy path

[bpasero]

Sandy can you check, I think this came in from #40575. I wonder why we don't just open the file on disk and why this needs a custom log viewer. We can mark the editor as readonly.

[jrieken]

also related to #192271 - the lack of these actions make it really hard to attach the sync-log to an issue

[sandy081]

Yeah, this is opened as log viewer to make it readonly. If we can mark readonly for normal files, then we do not need this spl log viewer.

[bpasero]

@sandy081 I think there are 2 options here:

• make the setting files.readonlyInclude dynamic by adding the logs folder by default
• ad-hoc configure the logs folder or logs file to open as readonly via the new IFilesConfigurationService.updateReadonly method

I think I would go with the second choice because that is quite straightforward.

[sandy081]

Adopted to ad-hoc readonly state change, but it is allowing user to write into the file

Is it possible to prevent that? I know user can open the file directly from the folder and can edit, but I would like to prevent this action when opened using the action in output

[bpasero]

currently not, but I don't think its a big deal