Log a lot more of the Microsoft Auth extension #192629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a ton more logging, a consistant format, and fixes the log levels of some. Additionally, there are two small fixes that I have included: * we were firing the `_sessionChangeEmitter` twice when a session was removed * when processing updates from other windows, we returned instead of continued... thus were only processing the first account that was added in another window
TylerLeonhardt
commented
Sep 8, 2023
| return Promise.resolve(undefined); | ||
| } | ||
|
|
||
| const token = this._tokens.splice(tokenIndex, 1)[0]; | ||
| const session = await this.removeSessionByIToken(token, writeToDisk); | ||
|
|
||
| if (session) { |
TylerLeonhardt
commented
Sep 8, 2023
| } | ||
|
|
||
| private async checkForUpdates(e: IDidChangeInOtherWindowEvent<IStoredSession>): Promise<void> { | ||
| for (const key of e.added) { | ||
| const session = await this._tokenStorage.get(key); | ||
| if (!session) { | ||
| this._logger.error('session not found that was apparently just added'); | ||
| return; | ||
| continue; |
TylerLeonhardt
commented
Sep 8, 2023
| } catch (e) { | ||
| // Network failures will automatically retry on next poll. | ||
| if (e.message !== REFRESH_NETWORK_FAILURE) { | ||
| vscode.window.showErrorMessage(vscode.l10n.t('You have been signed out because reading stored authentication information failed.')); | ||
| await this.removeSessionById(session.id); | ||
| } | ||
| return; | ||
| continue; |
joyceerhl
approved these changes
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ton more logging, a consistant format, and fixes the log levels of some.
Additionally, there are two small fixes that I have included:
_sessionChangeEmittertwice when a session was removedref #186693