Settings sync requiring login multiple times per day #186693
Comments
|
These logs are not talking about the login (authentication), can you please explain what you mean by multiple logins and after you login if settings sync works? When are you getting logged out? |
|
Last night I stepped away from my pc with vscode still open and sync working, and this morning when I came back to it, it made me sign in to sync again - where can I get logs of the issue? |
|
I also have the same problem. |
|
Same issue. |
|
@mendelgordon Please share following logs
|
|
@TylerLeonhardt Is this auth related? |
|
settings sync log.txt |
|
A few days ago there was an issue on the GitHub side that caused issues with Settings Sync. Are you still able to repro this today? If so... Can you follow these steps so that we can get more information on what's going on?
|
|
It most recently happened yesterday - if it happens again I'll enable the higher log level and wait for it to happen another time |
|
same issue. recently. |
|
Happened again last night - I signed in with microsoft and turned on the higher log level, and when I came to my pc today it made me sign in to microsoft again |
|
We've been making some changes to how credentials are stored recently so it's likely that. |
|
Your logs indicate that you have quite a few login sessions. Can you log out of your Microsoft: and tell me if it says that you're still logged in after that? |
|
I logged out of microsoft, and then it made me login to microsoft again to continue syncing my settings. |
|
So you signed out, and then saw that that account was no longer listed in the account menu, right? Can you share the Microsoft Auth & Window logs from this? |
|
Correct. Window: |
|
So at this point, are you are able to turn on Settings Sync? If that works, when you reload VS Code are you still logged in? |
|
Yes and yes
|
|
Ok. Thanks for confirming. I would like to see if you experience the same issue of a growing list of sessions again. If you hit this issue again, can you attach the logs again? We can leave this open. |
TylerLeonhardt
added
the
bug
@TylerLeonhardt Token is stored in the shared process where settings sync happens. Token is updated by the window (renderer), where I listen to the event you mentioned. I also re-request sessions when the existing token fails with 401. Since this happens on the window, do you think if there is a possibility that multiple windows are opened, and one of the windows is getting an invalid token from the auth extension ? |
|
@mendelgordon the next time this happens can you include:
With these things, @sandy081 and I will sit down and follow the flow and see what is going wrong/add more logs to get to the bottom of this. Thank you so much for providing everything you have so far, it's been helpful! |
|
Happened again: |
|
@mendelgordon Thanks for the logs. @TylerLeonhardt Lets go through the logs together and diagnose the issue. |
|
Monday's VS Code Insider build will have two things from my end:
@sandy081 is also planning (if he hasn't done it yet) to add more logs on the Settings Sync side so we can fill in the gaps of our logs. My recommendation for you @mendelgordon ... get VS Code Insiders if you don't have it already and use exclusively that to see if we can repro the issue. Make sure you have the If you see it, please once again, send those 4 Output channels. I really appreciate your patience here. This is a particularly pesky bug to track down... |
|
I'm also seeing this same issue, I'll switch to the Insider build next week and monitor this thread. I'm sure mendelgordon will follow up, but if not, I can also provide the logging or otherwise confirm if the issue is resolved. |
The idea here is... if a token is currently being refreshed, well then getting a token of those scopes should wait for that to finish. Core has a really nice `SequencerByKey` for exactly this kind of thing, and so I've stolen that and started to organize the code with a `common` folder. Oh, I also noticed we were sorting twice and fixed that to only sort once. ref #186693
…#192638) The idea here is... if a token is currently being refreshed, well then getting a token of those scopes should wait for that to finish. Core has a really nice `SequencerByKey` for exactly this kind of thing, and so I've stolen that and started to organize the code with a `common` folder. Oh, I also noticed we were sorting twice and fixed that to only sort once. ref #186693
|
@matthewpavkov it’s better if you provide the logs, since I stopped using GitHub copilot, and that seemingly makes the issue happen less often. |
|
@TylerLeonhardt I only have a few days of testing this, but so far the Insider build seems to work as expected. I have two accounts I'm connected to, one for syncing my settings (Microsoft) and one for Copilot (GitHub). I have not had to log into Microsoft every day like I normally do. It's only been a few days, I will continue monitoring and report back regardless next week. @mendelgordon FYI |
|
@TylerLeonhardt Everything looks good still, this seems to be resolved now. |
|
@matthewpavkov glad to hear! @mendelgordon how's it going for you? |
|
It's "only" signing me out approx. once a week, so I haven't bothered to get the logs - I still don't have copilot turned on so I'm not sure if that would make issues. |
|
Well, I'd love to figure out how to get it to not sign out at all 🙏 Copilot shouldn't affect this... but I'm curious if you do see a correlation these days. |
|
Happened again but I'm not sure if I reenabled the trace level before or after it happened - when and why does the log level get reset to the default? |
|
@mendelgordon looks like the important trace logging isn't there. Did you grab today's VS Code stable release 1.83? |
@sandy081 can you answer these? I think the 2nd question, the answer is "no", sadly. |
|
Only got it after the issue occurred |
|
Ok yeah. 1.83 does have this stuff I mentioned here: so I am eager to hear your experience post-update. |
|
I see in the update notes that there's a new option, Developer: Download Settings Sync Activity - is that something I should do the next time the issue occurs? Does that collect all of the logs needed, or would I still send the others as well? |
|
@sandy081 does that help us here at all? |
|
No, as this does not capture login activity. |
|
The issue went away after that update, and reactivating github copilot hasn't caused any issues here! |
Type: Bug
This is the error I see in the settings sync log:
2023-06-28 18:35:06.329 [info] Auto Sync: Triggered by Interval
2023-06-28 18:35:06.331 [info] Sync started.
2023-06-28 18:35:28.626 [info] Request failed https://vscode-sync.trafficmanager.net/v1/manifest
2023-06-28 18:35:28.626 [error] RequestFailed (UserDataSyncError) syncResource:unknown operationId:unknown: Connection refused for the request 'https://vscode-sync.trafficmanager.net/v1/manifest'.
at e.UserDataSyncStoreService.v (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:148871)
at async e.UserDataSyncStoreService.manifest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:146879)
at async e.UserDataSyncService.createSyncTask (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:120502)
at async r.C (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:110859)
at async r.z (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:110486)
2023-06-28 18:35:28.626 [error] RequestFailed (UserDataSyncError) syncResource:unknown operationId:unknown: Connection refused for the request 'https://vscode-sync.trafficmanager.net/v1/manifest'.
at e.UserDataSyncStoreService.v (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:148871)
at async e.UserDataSyncStoreService.manifest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:146879)
at async e.UserDataSyncService.createSyncTask (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:120502)
at async r.C (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:110859)
at async r.z (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:81:110486)
Microsoft isn't set to be used as an auth provider for any of my extensions so I'm really not sure what could be causing this
VS Code version: Code 1.79.2 (695af09, 2023-06-14T08:58:33.551Z)
OS version: Darwin arm64 22.5.0
Modes:
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Extensions (15)
A/B Experiments
The text was updated successfully, but these errors were encountered: