Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize terminal/context, terminal/title/context #192809

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Finalize terminal/context, terminal/title/context #192809

merged 6 commits into from
Sep 15, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 11, 2023

Fixes #79034

@Tyriar Tyriar added this to the September 2023 milestone Sep 11, 2023
@Tyriar Tyriar self-assigned this Sep 11, 2023
meganrogge
meganrogge previously approved these changes Sep 11, 2023
@Tyriar Tyriar marked this pull request as draft September 11, 2023 19:10
@Tyriar
Copy link
Member Author

Tyriar commented Sep 11, 2023

This needs to pass the terminal context through still, marking draft

@Tyriar Tyriar marked this pull request as ready for review September 15, 2023 16:07
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, but looks good otherwise

@Tyriar Tyriar merged commit d5d1456 into main Sep 15, 2023
5 of 6 checks passed
@Tyriar Tyriar deleted the tyriar/79034 branch September 15, 2023 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to contribute context menu entries for Terminal
3 participants