Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to contribute context menu entries for Terminal #79034

Closed
usernamehw opened this issue Aug 13, 2019 · 11 comments · Fixed by #192809
Closed

Ability to contribute context menu entries for Terminal #79034

usernamehw opened this issue Aug 13, 2019 · 11 comments · Fixed by #192809
Assignees
Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues

Comments

@usernamehw
Copy link
Contributor

I want to contribute menu items for Terminal. Doesn't look like it's possible now:

https://code.visualstudio.com/api/references/contribution-points#contributes.menus

@vscodebot
Copy link

vscodebot bot commented Aug 13, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues api labels Aug 13, 2019
@Tyriar
Copy link
Member

Tyriar commented Aug 13, 2019

I guess terminal/context makes sense given the other keys

@Tyriar Tyriar added this to the October 2019 milestone Oct 9, 2019
@Tyriar
Copy link
Member

Tyriar commented Oct 9, 2019

Adding to October to discuss, this won't be implemented in October.

@Tyriar
Copy link
Member

Tyriar commented Oct 14, 2019

Brought up in API sync today, approved to go ahead for a proposed API using terminal/context and passing the underlying Terminal object to the callback.

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 14, 2019
@Tyriar Tyriar modified the milestones: October 2019, Backlog Oct 14, 2019
@Tyriar Tyriar modified the milestones: Backlog, February 2020 Feb 3, 2020
@nickyhajal
Copy link

Looking forward to using this for an extension, thanks for moving it forward.

Might it be possible to include context menu contribution points for problems/context, output/context, debug-console/context, etc?

Also, is support for passing or accessing currently selected text in those views possible?

@Tyriar
Copy link
Member

Tyriar commented Feb 18, 2020

Might it be possible to include context menu contribution points for

That would need to be separate feature requests.

Also, is support for passing or accessing currently selected text in those views possible?

That's not the current thinking. Could be useful though...

@Kingwl
Copy link
Contributor

Kingwl commented May 12, 2020

I'd like to work on this.

@Tyriar
Copy link
Member

Tyriar commented May 12, 2020

@Kingwl sounds good 👍 I haven't actually dealt with adding something like this yet so I would search the codebase for similar context menu contributions for other components like the explorer.

@gar1t
Copy link

gar1t commented Jun 20, 2022

I would add, also, that menu support ought to be available for termina/title to provide more visibility into actions/commands available for a terminal session. Context menus are great but my concern is that since this would be new functionality, users might not have any idea that there are useful functions hiding in the already pretty full context menus. Having menus visible in the title area would be important I think.

+1 to extend this to output, problem, etc. as per @nickyhajal's suggestion.

My extension makes extensive use of system commands via the terminal that tie user work via editors to a CLI based program. A particular terminal is associated with a particular operation/goal, which may have various other VS Code commands associated with it. There's currently no decent way to tie commands to that terminal/operation. It seems that the menu facility that's widely available in other areas (editors, explorer, source code, etc.) is painfully missing for terminals, output, problems, etc.

Tyriar added a commit that referenced this issue Aug 9, 2023
- Adds the API
- Consolidates the editor and view terminal menus
- Removes the Show Tabs entry as tabs are very old now

Part of #79034
Tyriar added a commit that referenced this issue Aug 9, 2023
- Adds the contribution
- Consolidates inline tab and tab list menu
- Renamed '...Instance' commands to be less ambiguous

Part of #79034
@Tyriar
Copy link
Member

Tyriar commented Aug 9, 2023

This is done and TPI is created, so moving this to next iteration

@Tyriar Tyriar modified the milestones: August 2023, September 2023 Aug 9, 2023
@Tyriar Tyriar removed the on-testplan label Sep 7, 2023
Tyriar added a commit to microsoft/vscode-docs that referenced this issue Sep 15, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 15, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 18, 2023
gregvanl pushed a commit to microsoft/vscode-docs that referenced this issue Sep 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants