Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing L on a non-expandable reference item shows an error notification (with vim extension) #193468

Closed
ulugbekna opened this issue Sep 19, 2023 · 0 comments · Fixed by #199996
Closed

Pressing L on a non-expandable reference item shows an error notification (with vim extension) #193468

ulugbekna opened this issue Sep 19, 2023 · 0 comments · Fixed by #199996
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders tree-widget Tree widget issues verified Verification succeeded
Milestone
December / Januar...

Comments

@ulugbekna
Copy link
Contributor

ulugbekna commented Sep 19, 2023 •
edited

Description

With the vim extension installed, one can navigate the references tree (triggered by "Go to references") using h, j, k, l.

Pressing l on an expandable tree item expands the item, while on a non-expandable item - it should go that reference (what cmd+down does), but now it shows an error notification

See:

Screen.Recording.2023-09-19.at.16.04.10.mov

Repro

  1. trigger "go to references" on a symbol with at least 1 reference
  2. press l on a non-expandable (i.e., reference) node -> see the error notification

Version info

Version: 1.83.0-insider
Commit: bccfade64adb249f57c8fcf03cba41609f76ce5c
Date: 2023-09-15T05:38:00.328Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.6.0

vim extension v1.26.0
@ulugbekna ulugbekna changed the title Pressing L on a non-expandable reference item shows an error notification Pressing L on a non-expandable reference item shows an error notification (with vim extension) Sep 19, 2023
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Sep 21, 2023
@joaomoreno joaomoreno added this to the September 2023 milestone Sep 21, 2023
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Sep 21, 2023
@joaomoreno joaomoreno modified the milestones: September 2023, Backlog Sep 27, 2023
@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Sep 27, 2023
@audreygao audreygao mentioned this issue Dec 5, 2023
Merged
@joaomoreno joaomoreno modified the milestones: Backlog, December / January 2024 Dec 20, 2023
joaomoreno added a commit that referenced this issue Dec 20, 2023
@audreygao @joaomoreno
Fix #193468 - Fix bug with error notification when pressing "l" on no…
3051ae8 
…n-expandable reference item. (#199996)

* Fix the bug that pressing l key on non-expandable reference item shows error notification (with vim extension)

* 💄

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 20, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 3, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
December / January 2024
5 participants
@joaomoreno @ulugbekna @eleanorjboyd @aiday-mar @VSCodeTriageBot