Should panel toggle keybindings focus instead of toggle when the panel is not active?

[Tyriar]

Currently all the panel toggle commands hide the respective panel when it's visible and show it when it's hidden. I find this annoying though and instead use the following custom keybinding:

{
  "key": "ctrl+`",
  "command": "workbench.action.terminal.focus",
  "when": "!terminalFocus"
}

This overrides the setting when the terminal does not have focus to simply focus it, but retain the hide behavior when it is focused. This means you don't have to hit ctrl+` twice in order to get focus to the terminal when it's already displayed but not focused. This does change the hiding the terminal case when it's not focused to need 2 ctrl+`'s but personally I hardly ever do this compared to switching focus from the editor to the terminal.

I frequently tell users about my config and they all react positively so I'm wondering whether we should make this the default behavior for all panels (to keep them consistent).

/discuss

[daviwil]

I believe this should be the default behavior because it aligns with user intent: no matter where I'm at in the editor, if I hit the hotkey it should bring me to the respective panel. If I'm already there I probably want to toggle it.

[bpasero]

I am ok changing this, the sidebar behaves the same (focus in when not focussed and invoking the keybinding). As long as we provide a way to configure the old behaviour.

[kaiwood]

Should be changed, yes. I'm using almost exclusively using workbench.action.focusPanel as soon as the terminal is active because I can't stand the do-2-things-at-once-behaviour of workbench.action.terminal.focus.

Consistency with the sidebar would be a big plus 👍

[isidorn]

I am fine with changing this to behave like the sidebar. Especially if the users seem to prefer this. They can always use cmd + J to toggle

[sandy081]

This was brought up already before - #7540