Not possible to trigger actions below reply input as a keyboard user?

[joyceerhl]

Testing #194012

After I focus a comment, I can tab to the actions in the comments title area, but I don't see a way to get focus to the 'Resolve Conversation' button or the 'Make a Suggestion' button. 'Resolve Conversation' is at least exposed in the command palette, so it is triggerable with a keybinding, but I would expect the other actions to also be focusable or triggerable from the palette:

• Make a Suggestion
• Start Review
• Add Comment

[meganrogge]

You need to enable tab moves focus mode, ctrl+m on windows.

We should probably add a keybinding for each of the actions.

[meganrogge]

From a visual standpoint, the tab order looks funny (right to left), but IMO, it makes the most sense to have them prioritized as they are:

• Add comment
• Start review
• Make a suggestion

[meganrogge]

We should also mention here that there are actions to be tabbed to and state that, to reach them, tab moves focus mode must be on.

[joyceerhl]

I don't think we necessarily need keybindings for these, just exposing the functionality as commands in the palette would help

[alexr00]

These actions are contributed by GHPRI. I'll update their context so they show in the command palette when you're editing a comment.

[alexr00]

Actually, we close the comment editor when the command palette is shown, so I can't just make this change in the extension. I can look into this in October if we want to change it.

[alexr00]

I've looked into this further:

• All the buttons are accessible when you use tab moves focus ✅
• I can make the comment editor stay open when the command palette is opened, but any command executed from the command palette at this time will not have the correct comment context.

Since the buttons are accessible I'm going to close.