allow commands to run from terminal accessible view

[meganrogge]

Allows a SR user to go back to the accessible view after invoking Run Recent Command, Go to Recent Directory, or when escaping from Open detected link

fixes #193988

[Tyriar]

This is a pretty big change to go in after testing, it doesn't seem too critical as it's about canceling an action so would it be better to merge in October?

[meganrogge]

I wondered about that, but this is a regression bc the following worked before:

• open accessible buffer
• run recent command
• focus remains in accessible buffer

Without this change:

• open accessible view
• run recent command
• focus is lost

With this change:

• open accessible view
• run recent command
• focus is in accessible view

[meganrogge]

Actually, the above case can be fixed by setting focusAfterRun to accessible-buffer

[Tyriar]

Instead of firing an event with an id back to another provider (circular dep), can we indicate in the show call that we want to go back upon exit/close. Then manage it all inside the a11y view service?

[meganrogge]

No, because at the time of the show call, we don't know that we want to go back.

Show is called before run recent command is invoked for example.

[Tyriar]

But the service knows what came before, so the second provider could signal that it was canceled and it should open the one before. For example, onClose: Event<{ reopenLast: boolean }>?

[meganrogge]

The issue is we only want to reopen last onClose for certain cases. And the provider isn't aware of what those cases are.

[meganrogge]

I'm not sure what you mean by "second provider" 🤔 . The parties of interest here are the original provider and the quick-pick / action that interrupts / hides it temporarily.

[Tyriar]

Oh I get it. It just feels a little flimsy right now and easily breakable. Could we do something to make it more reliable? Tests that verify it interacts nicely with the second quick pick would be good

[meganrogge]

Hmm, I think smoke tests would be needed for that?

[meganrogge]

could be good, but I can just imagine the flakes now... 😅

[Tyriar]

Smoke tests would be best yeah. I would think they'd be fairly reliable if all they do is verify the view is up, not validate the contents.