[Accessibility] Cannot clear terminal buffer using shortcut key

[jooyoungseo]

Type: Bug

If you assign a keybinding for clear terminal command and press the key in the accessible terminal buffer, it does not work.

keybindings:

[
  {
    "key": "ctrl+l",
    "command": "workbench.action.terminal.clear",
    "when": "terminalFocus && terminalHasBeenCreated || terminalAccessibleBufferFocus && terminalHasBeenCreated"
  }
]

• Note: ctrl+l only works in terminal input, not terminal buffer.

VS Code version: Code - Insiders 1.83.0-insider (aad333b, 2023-09-28T05:34:00.540Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item	Value
CPUs	11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	15.71GB (6.02GB free)
Process Argv	--crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader	yes
VM	0%

Extensions (92)

Extension	Author (truncated)	Version
android-dev-ext	ade	1.3.2
aiprm-lang	AIP	0.0.2
Bookmarks	ale	13.4.1
openscad	Ant	1.2.1
spellright	ban	3.0.118
zoterolatex	bna	0.4.1
mermaid-markdown-syntax-highlighting	bpr	1.5.2
doxdocgen	csc	1.4.0
vscode-markdownlint	Dav	0.52.0
vscode-eslint	dba	2.4.2
vscode-quick-select	dba	0.2.9
vscode-deno	den	3.25.0
gitlens	eam	14.3.0
EditorConfig	Edi	0.16.4
prettier-vscode	esb	10.1.0
vscode-google-translate	fun	1.4.13
codespaces	Git	1.15.4
copilot	Git	1.117.446
copilot-chat	Git	0.8.2023092701
remotehub	Git	0.60.0
vscode-github-actions	git	0.26.2
vscode-pull-request-github	Git	0.72.0
overleaf-workshop	iam	0.2.4
cslpreview	igo	0.2.2
easy-snippet	inu	0.6.3
path-autocomplete	ion	1.25.0
latex-workshop	Jam	9.14.0
lilypond-syntax	jea	0.1.1
scheme	jea	0.2.0
better-cpp-syntax	jef	1.17.2
vscode-bard	jim	0.0.10
google-search	kam	0.0.1
vscode-lua-format	Koi	1.3.8
lilypond-formatter	lhl	0.2.3
lilypond-pdf-preview	lhl	0.2.8
lilypond-snippets	lhl	0.1.1
vslilypond	lhl	1.7.3
zotero	mbl	0.1.10
git-graph	mhu	1.30.0
vscode-docker	ms-	1.26.1
black-formatter	ms-	2023.4.1
flake8	ms-	2023.6.0
isort	ms-	2023.11.12711013
python	ms-	2023.16.0
vscode-pylance	ms-	2023.9.20
jupyter	ms-	2023.8.1002501831
jupyter-keymap	ms-	1.1.2
jupyter-renderers	ms-	1.0.17
vscode-jupyter-cell-tags	ms-	0.1.8
vscode-jupyter-slideshow	ms-	0.1.5
remote-containers	ms-	0.313.0
remote-ssh	ms-	0.106.4
remote-ssh-edit	ms-	0.86.0
remote-wsl	ms-	0.81.5
vscode-remote-extensionpack	ms-	0.24.0
azure-repos	ms-	0.36.0
cmake-tools	ms-	1.15.31
cpptools	ms-	1.17.5
cpptools-extension-pack	ms-	1.3.0
js-debug-nightly	ms-	2023.9.2717
powershell	ms-	2023.6.0
remote-repositories	ms-	0.38.1
vscode-github-issue-notebooks	ms-	0.0.130
vscode-selfhost-test-provider	ms-	0.3.18
vscode-serial-monitor	ms-	0.10.0
vsliveshare	ms-	1.0.5883
autodocstring	njp	0.6.1
pandocciter	not	0.10.3
shiny-python	Pos	0.1.4
shinyuieditor	pos	0.5.0
quarto	qua	1.100.0
r-debugger	RDe	0.5.4
java	red	1.22.1
vscode-xml	red	0.26.1
r	REd	2.8.1
multi-command	ryu	1.6.0
vscode-deepl	soe	1.0.6
abc-music	sof	0.4.0
lua	sum	3.7.0
latex-utilities	tec	0.4.10
cmake	twx	0.0.17
errorlens	use	3.14.0
intellicode-api-usage-examples	Vis	0.2.8
vscodeintellicode	Vis	1.2.30
vscode-arduino	vsc	0.6.0
vscode-java-debug	vsc	0.54.0
vscode-java-dependency	vsc	0.23.1
vscode-java-pack	vsc	0.25.14
vscode-java-test	vsc	0.40.0
vscode-maven	vsc	0.42.0
markdown-all-in-one	yzh	3.5.1
grammarly	znc	0.22.1

(1 theme extensions excluded)

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
ecj1e332:30687743
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
copilotsettingt:30808721
asynctok:30821568
dsvsc013:30777762
dsvsc014:30777825
diffeditorv2:30786206
pythonlinttype:30823781
pythonmpsinfo:30842935
dsvsc015:30821418
pythontestfixt:30826906
pythonfb280951:30830809
pythonregdiag:30842812
pythoncet0:30848247

[meganrogge]

This is expected ATM, but an understandable request.

Most of the terminal commands do not apply to the terminal accessible view because it is readonly.

From a pragmatic standpoint, I can see that we should support this.

Related to #194246

[jooyoungseo]

If you try this command with command palette instead of the shortcut key, this works.

[meganrogge]

@jooyoungseo when I focus the accessible view and invoke clear from the command palette, focus is lost

[meganrogge]

Oh, I just realized that terminalAccessibleBufferFocus is now deprecated. It works if you change that to accessibleViewCurrentProviderId == 'terminal'

[meganrogge]

I think it makes sense to make that work by default in the accessible view when in screen reader mode.