-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Running Extension > Start Extension Host Profile button does nothing #194678
Show Running Extension > Start Extension Host Profile button does nothing #194678
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.3. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
Ok, I reproduced this with the latest insiders build & updated the PR description with my insiders version. |
This sends the SIGUSR1 signal which on windows doesn't exist. We have or used to have an alternative for that the utility process might not support that? |
I am unable to repro with latest insiders, can you try the following steps to narrow down the issue
|
Great, the output indicates the process has the inspector agent started on
|
Thanks for confirming, @jrieken looks like the inspector agent is working fine for the user, so indicates an issue in the inspector client code path. For this action, the client we use is the profilingservice based on vscode/src/vs/workbench/contrib/extensions/electron-sandbox/runtimeExtensionsEditor.ts Line 144 in f1c3b1d
|
At least for me this seems to be because the profiler interface is trying to connect to The profile module also eats the underyling error which makes it a little harder to troubleshoot https://github.com/jrieken/v8-inspect-profiler/blob/master/index.js#L47-L52 |
Fixes #194678. Requires jrieken/v8-inspect-profiler#3 to be merged and published in order to pass the 'host' down.
* exthost: fix profiling not working Fixes #194678. Requires jrieken/v8-inspect-profiler#3 to be merged and published in order to pass the 'host' down. * bump package
@deepak1556 @connor4312 Hi, just a question, the extension host profile command works well for me, but how should I analyze extension host performance in |
Chrome devtools records performance, you need to look in the area for the web worker extension host. |
Got it! Thanks! |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
Developer: Show Running Extension
Expected:
It starts an extension host profile, turning the icon into a square. Clicking the icon again shows an extension profile, showing which extensions too the most time.
Actual:
Clicking the button does nothing.
The text was updated successfully, but these errors were encountered: