do not shrink cell if still executing #195283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
Oct 10, 2023
This was referenced Oct 10, 2023
rebornix
reviewed
Oct 10, 2023
| if (synchronous) { | ||
| this.viewCell.unlockOutputHeight(); | ||
| } else { | ||
| } else if (executionState?.state !== NotebookCellExecutionState.Executing) { | ||
| this._outputHeightTimer = setTimeout(() => { |
There was a problem hiding this comment.
It's possible that execution state is still Executing when we finish the output update (for example, the cell is executing but there is no more outputs). We need a listener on cell execution state change to ensure that we always unlock the output height at the end.
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194516