Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff view is not shown for copilot inline chat /fix for screen reader user #196047

Closed
Tracked by #200459
meganrogge opened this issue Oct 19, 2023 · 4 comments · Fixed by #196561
Closed
Tracked by #200459

diff view is not shown for copilot inline chat /fix for screen reader user #196047

meganrogge opened this issue Oct 19, 2023 · 4 comments · Fixed by #196561
Assignees
@jrieken @hediet
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2023

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Oct 19, 2023 •
edited

  • Enable screen reader mode or use preview mode
  • Create a code error
  • Invoke inline chat and use /fix
  • The response doesn't get shown in the diff editor and sometimes doesn't come back at all.
  • The console shows the error below
mainThreadExtensionService.ts:81 [GitHub.copilot-chat]Progress reporting is only supported for live sessions
$onExtensionRuntimeError @ mainThreadExtensionService.ts:81
mainThreadExtensionService.ts:82 Error: Progress reporting is only supported for live sessions
    at Object.report (/Applications/Visual Studio Code - Insiders bad.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:34170)
    at t._reportProgress (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.9.2023101901/dist/extension.js:380:1604)
    at t.finish (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.9.2023101901/dist/extension.js:380:1813)
    at t.fetchResponse (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.9.2023101901/dist/extension.js:991:2429)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at t.provideInteractiveEditorResponse (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.9.2023101901/dist/extension.js:989:2067)
    at I.$provideResponse (/Applications/Visual Studio Code - Insiders bad.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:127:34502)
@meganrogge

This comment was marked as outdated.

Sign in to view
@jrieken jrieken added the ~info-needed Issue requires more information from poster (with bot comment) label Oct 20, 2023
@VSCodeTriageBot

This comment was marked as resolved.

Sign in to view
@VSCodeTriageBot VSCodeTriageBot added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Oct 20, 2023
@meganrogge

This comment was marked as duplicate.

Sign in to view
@meganrogge meganrogge removed the info-needed Issue requires more information from poster label Oct 20, 2023
@meganrogge

This comment was marked as outdated.

Sign in to view
@jrieken jrieken added this to the October 2023 milestone Oct 23, 2023
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug inline-chat labels Oct 24, 2023
@jrieken jrieken mentioned this issue Oct 25, 2023
Merged
jrieken added a commit that referenced this issue Oct 25, 2023
@jrieken
only check true edit progress chunks against the live flag, preview…
347e80a 
… must diff against the right, ad-hoc model

fixes #196047
jrieken added a commit that referenced this issue Oct 25, 2023
@jrieken
only check true edit progress chunks against the live flag, preview…
6bb118a 
… must diff against the right, ad-hoc model (#196561)

fixes #196047
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 25, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@jrieken @Alex0007
only check true edit progress chunks against the live flag, preview…
ac3c8c8 
… must diff against the right, ad-hoc model (microsoft#196561)

fixes microsoft#196047
@meganrogge meganrogge added the verified Verification succeeded label Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2023
4 participants
@jrieken @hediet @meganrogge @VSCodeTriageBot