Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to theme diff highlights #19735

Closed
Tyriar opened this issue Feb 2, 2017 · 5 comments
Closed

Provide a way to theme diff highlights #19735

Tyriar opened this issue Feb 2, 2017 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 2, 2017

Right now themes cannot determine the colors of the git diff highlight colors meaning that if you want the theme to be readable you must select foreground colors that have sufficient contrast on both the green and the red colors.

This image has uses a comment foreground that looks great on the background but is completely unreadable on the light green diff highlight:

image

Ideally themes would be able to define this color since the color appears within the editor.

@Tyriar Tyriar added git GIT issues themes Color theme issues labels Feb 2, 2017
@joaomoreno joaomoreno removed their assignment Feb 3, 2017
@sandy081 sandy081 added the feature-request Request for new features or functionality label Feb 3, 2017
@rotemdan
Copy link

rotemdan commented Feb 4, 2017

I was just about to suggest this ;)

Also, it would be nice to be able to customize the colors of the small vertical marks that appear for changes in the code (I'm not sure how they are called). It would be cool to be able to aesthetically match them with the theme colors :), and make sure they have sufficient contrast for darker themes, I guess.

clipboard01

@akamud
Copy link
Contributor

akamud commented Feb 5, 2017

+1, people are asking for this for my theme

@tinacious
Copy link

+1 – I would also love to support this in my theme! 😄

Highlighted line additions are completely unreadable with my theme's comment colour (a lighter grey on a dark grey). It would be great to be able to change the diff colours (at least the foreground).

image

@akamud
Copy link
Contributor

akamud commented Apr 19, 2017

I see this is closed, but can you provide more info about what theme creators need to do to provide coloring for diff?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 19, 2017

@akamud the public API is still being worked on so we don't have documentation for it yet.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

8 participants