Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarized coloration does not work on a diff file #20144

Closed
mrvkino opened this issue Feb 7, 2017 · 4 comments
Closed

Solarized coloration does not work on a diff file #20144

mrvkino opened this issue Feb 7, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone

Comments

@mrvkino
Copy link

mrvkino commented Feb 7, 2017

The default Solarized Dark or Light does not color the text in a diff file (actual diff or patch file).

  • VSCode Version: 1.9.0
  • OS Version: Macos 10.12.3

Steps to Reproduce:

  1. Use the default VSCode Solarized theme and the text is grey
  2. Open a diff or patch file
  3. Change for another theme like Red to see the diff file text be in color
@Tyriar
Copy link
Member

Tyriar commented Feb 7, 2017

Duplicate #19735

@Tyriar Tyriar closed this as completed Feb 7, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 7, 2017
@mrvkino
Copy link
Author

mrvkino commented Feb 7, 2017

I am talking about an actual diff or patch file used to patch C code. Not the diff view generated by VSCode for the git integration.

#19735 seems more about the diff view from the git sidebar.

I have updated the issue explanation to clarify that I am talking about the actual file and not the git view from VSCode.

@Tyriar
Copy link
Member

Tyriar commented Feb 7, 2017

@mrvkino thanks for the clarification can you post a screenshot of the issue?

@Tyriar Tyriar reopened this Feb 7, 2017
@Tyriar Tyriar removed the *duplicate Issue identified as a duplicate of another issue(s) label Feb 7, 2017
@Tyriar Tyriar added the themes Color theme issues label Feb 7, 2017
@mrvkino
Copy link
Author

mrvkino commented Feb 7, 2017

Here is the Solarized theme version:
diff_patch

Here is the red theme version:
diff_patch_red

Thanks.

@aeschli aeschli added this to the February 2017 milestone Feb 20, 2017
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Feb 20, 2017
@bpasero bpasero added the verified Verification succeeded label Feb 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants