Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IdleValue and runWhenIdle into browser #197661

Closed
jrieken opened this issue Nov 7, 2023 · 1 comment · Fixed by #197721
Closed

Move IdleValue and runWhenIdle into browser #197661

jrieken opened this issue Nov 7, 2023 · 1 comment · Fixed by #197721
Assignees
@jrieken
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
November 2023

Comments

@jrieken
Copy link
Member

jrieken commented Nov 7, 2023

For some reason I added them into the common layer, however the idle callback is a concept of the browser, only available inside window and worker contexts. This should be cleaned up
@jrieken jrieken self-assigned this Nov 7, 2023
@jrieken jrieken added the debt Code quality issues label Nov 7, 2023
@jrieken jrieken added this to the November 2023 milestone Nov 7, 2023
@jrieken jrieken mentioned this issue Nov 7, 2023
Merged
jrieken added a commit that referenced this issue Nov 7, 2023
@jrieken
workaround layer breaker where dom-API is dependent on from common
2d65656 
workaround #197661
jrieken added a commit that referenced this issue Nov 7, 2023
@jrieken
workaround layer breaker where dom-API is dependent on from common (#…
2738622 
…197662)

workaround #197661
@bpasero
Copy link
Member

bpasero commented Nov 7, 2023

👍 , yeah I actually wanted to follow up with you on that.

@jrieken jrieken mentioned this issue Nov 8, 2023
Merged
jrieken added a commit that referenced this issue Nov 8, 2023
@jrieken
Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle a…
c86d1ca 
…nd runWhenWindowIdle.

Define window things inside dom.ts for more clarity and more correct layering.

Duplicate API definition for idle so that things compile standalone

fixes #197661
jrieken added a commit that referenced this issue Nov 8, 2023
@jrieken
Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle a…
dff4173 
…nd runWhenWindowIdle. (#197721)

* Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle.

Define window things inside dom.ts for more clarity and more correct layering.

Duplicate API definition for idle so that things compile standalone

fixes #197661

* fix compile errors

* make treeshaker happy, use correct types
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
November 2023
3 participants
@bpasero @jrieken @VSCodeTriageBot