Add WindowIdleValue and GlobalIdleValue, likewise runWhenGlobalIdle and runWhenWindowIdle. #197721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd runWhenWindowIdle. Define window things inside dom.ts for more clarity and more correct layering. Duplicate API definition for idle so that things compile standalone fixes #197661
bpasero
previously approved these changes
Nov 8, 2023
bpasero
approved these changes
Nov 8, 2023
bpasero
requested changes
Nov 8, 2023
There was a problem hiding this comment.
@jrieken actually looks like monaco standalone editor compilation issue:
Error: vs/base/browser/dom.ts(198,36): error TS2345: Argument of type '(idle: IdleDeadline) => void' is not assignable to parameter of type '(idle: import("/home/runner/work/vscode/vscode/out-editor-esm/vs/base/common/async").IdleDeadline) => void'.
Types of parameters 'idle' and 'idle' are incompatible.
Property 'didTimeout' is missing in type 'import("/home/runner/work/vscode/vscode/out-editor-esm/vs/base/common/async").IdleDeadline' but required in type 'IdleDeadline'.
The TS Compilation failed, preparing analysis folder...
Open in VS Code the folder at '/home/runner/work/vscode/vscode-monaco-editor-esm-analysis' and you can analyze the compilation error
[11:47:53] 'editor-esm-bundle' errored after 1.7 min
[11:47:53] Error: Standalone Editor compilation failed. If this is the build machine, simply launch `yarn run gulp editor-distro` on your machine to further analyze the compilation problem.
at /home/runner/work/vscode/vscode/build/gulpfile.editor.js:201:10
at async _execute (/home/runner/work/vscode/vscode/build/lib/task.js:25:5)
at async result (/home/runner/work/vscode/vscode/build/lib/task.js:64:13)
error Command failed with exit code 1.
|
next try, 🤞 |
alexr00
approved these changes
Nov 8, 2023
bpasero
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define window things inside dom.ts for more clarity and more correct layering.
Duplicate API definition for idle so that things compile standalone
fixes #197661