-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fine tune when native text area is updated #198153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like returning on |
meganrogge
commented
Nov 13, 2023
Tyriar
previously requested changes
Nov 14, 2023
meganrogge
changed the title
for some events, only
only update native text area content on Nov 14, 2023
writeScreenReaderContent
when screen reader is enabledrender
when in screen reader mode
meganrogge
changed the title
only update native text area content on
only update native text area content when in screen reader mode
Nov 14, 2023
render
when in screen reader mode
meganrogge
changed the title
only update native text area content when in screen reader mode
fine tune when native text area is updated
Nov 14, 2023
meganrogge
force-pushed
the
merogge/write-screen-reader
branch
from
November 14, 2023 22:18
636dc94
to
b92bc33
Compare
Code change looks good, but I don't have enough context to do a proper review. |
hediet
approved these changes
Nov 21, 2023
Lets merge and test properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function called
writeScreenReaderContent
was also used for other things:vscode/src/vs/editor/browser/controller/textAreaInput.ts
Lines 463 to 464 in 84aa769
I have renamed it
writeNativeTextAreaContent
as that's what I believe it represents.Skipping the update when the reason is
render
when not in screen reader mode has performance benefits and doesn't break anything. I've tried other variants and it breaks smoke tests.fix #192278