Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting of large folded regions is slow. Time spent in writeScreenReaderContent #192278

Closed
aeschli opened this issue Sep 6, 2023 · 3 comments · Fixed by #198153
Closed

Selecting of large folded regions is slow. Time spent in writeScreenReaderContent #192278

aeschli opened this issue Sep 6, 2023 · 3 comments · Fixed by #198153
Assignees
@hediet @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues editor-input Editor text input insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 6, 2023 •
edited
Loading

Investigating #192257
@aeschli
Copy link
Contributor Author

aeschli commented Sep 6, 2023

image

Big contents of selected text are written to the screenreader content, which seems to take a long time to render.
I don't have a screenreader enabled.

@aeschli
Copy link
Contributor Author

aeschli commented Sep 6, 2023

Trace-20230906T105957.zip

@aeschli aeschli changed the title Selecting of folded regions is vey slow Selecting of folded regions is vey slow. Time spent in writeScreenReaderContent Sep 6, 2023
@aeschli aeschli changed the title Selecting of folded regions is vey slow. Time spent in writeScreenReaderContent Selecting of large folded regions is slow. Time spent in writeScreenReaderContent Sep 6, 2023
@aeschli aeschli assigned meganrogge and hediet and unassigned aeschli Sep 6, 2023
@meganrogge
Copy link
Contributor

cc @alexdima

@meganrogge meganrogge added this to the October 2023 milestone Sep 12, 2023
@meganrogge meganrogge removed this from the October 2023 milestone Oct 20, 2023
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug debt Code quality issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Nov 13, 2023
meganrogge added a commit that referenced this issue Nov 13, 2023
@meganrogge
fix #192278
64fd258
@meganrogge meganrogge mentioned this issue Nov 13, 2023
Merged
@meganrogge meganrogge added this to the November 2023 milestone Nov 13, 2023
@meganrogge meganrogge added editor-input Editor text input and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Nov 13, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 21, 2023
@aeschli aeschli added the verified Verification succeeded label Nov 29, 2023
@aeschli aeschli mentioned this issue Dec 18, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues editor-input Editor text input insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

fine tune when native text area is updated microsoft/vscode
4 participants
@hediet @aeschli @meganrogge @vscodenpa