Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak in defaultWorkerFactory #198709

Closed
SimonSiefke opened this issue Nov 20, 2023 · 0 comments · Fixed by #198710
Closed

memory leak in defaultWorkerFactory #198709

SimonSiefke opened this issue Nov 20, 2023 · 0 comments · Fixed by #198710
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders

Comments

@SimonSiefke
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.84.2
  • OS Version: Ubuntu 23.04

Steps to Reproduce:

Test Script

(Unfortunately the test doesn't work on macos, but it should work on windows and linux):

git clone git@github.com:SimonSiefke/vscode-memory-leak-finder.git &&
cd vscode-memory-leak-finder &&
git checkout v5.25.0 &&
npm ci &&
node packages/cli/bin/test.js --cwd packages/e2e  --check-leaks --measure-after --measure event-listeners  --only explorer.set-files &&
cat .vscode-memory-leak-finder-results/event-listeners/explorer.set-files.json

Output

{
  "eventListeners": [
    {
      "type": "error",
      "description": "(err) => {\n                (0, simpleWorker_1.logOnceWebWorkerWarning)(err);\n                this._webWorkerFailedBeforeError = err;\n                onErrorCallback(err);\n            }",
      "stack": ["listener (vscode/out/vs/base/browser/defaultWorkerFactory.js:127:111)"],
      "count": 1,
      "originalStack": ["vscode/src/vs/base/browser/defaultWorkerFactory.ts:155:102"],
      "originalName": null
    },
    {
      "type": "message",
      "description": "function (ev) {\n                    onMessageCallback(ev.data);\n                }",
      "stack": ["listener (vscode/out/vs/base/browser/defaultWorkerFactory.js:88:39)"],
      "count": 1,
      "originalStack": ["vscode/src/vs/base/browser/defaultWorkerFactory.ts:105:27"],
      "originalName": null
    }
  ],
  "isLeak": true
}
@lramos15 lramos15 assigned alexdima and unassigned lramos15 Nov 20, 2023
@alexdima alexdima added this to the December 2023 milestone Dec 4, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants