Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak in defaultWorkerFactory #198710

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: memory leak in defaultWorkerFactory #198710

merged 1 commit into from
Dec 5, 2023

Conversation

SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented Nov 20, 2023 •
edited
Loading

Fixes #198709

Output

Running the same test as in the issue description now gives the following results:

{
  "eventListeners": [],
  "isLeak": false
}

@ulugbekna ulugbekna removed the request for review from bpasero November 20, 2023 22:10
@ulugbekna ulugbekna removed their assignment Nov 20, 2023
@bpasero bpasero assigned alexdima and jrieken and unassigned bpasero Nov 21, 2023
@alexdima alexdima added this to the December 2023 milestone Dec 4, 2023
alexdima
alexdima approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexdima alexdima merged commit d13bfe5 into microsoft:main Dec 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@alexdima alexdima alexdima approved these changes

Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak in defaultWorkerFactory
7 participants
@SimonSiefke @joaomoreno @alexdima @bpasero @jrieken @ulugbekna @VSCodeTriageBot