Malformed link in notification to open workspace

[joyceerhl]

1. Configure display language e.g. to French
2. Open a repo that contains a workspace file
3. Get notification which says this, 🐛 the markdown link is not rendered

Ce dossier contient un fichier d’espace de travail 'workspace.code-workspace'. Voulez-vous l’ouvrir ? [En savoir plus] (https://go.microsoft.com/fwlink/?linkid=2025315) sur les fichiers de l’espace de travail.

[bpasero]

This: [En savoir plus] (https://go.microsoft.com/fwlink/?linkid=2025315)
Needs to be: [En savoir plus](https://go.microsoft.com/fwlink/?linkid=2025315)

[TylerLeonhardt]

We should use locking comments (a feature of our localization pipeline) to enforce this.

    comment: ['{Locked="STRING TO LOCK IN PLACE"}']

Using the other signature of localize:

localize(
  {
    key: 'workspaceFound',
    comment: ['{Locked="]({1})"}']
  },
  "This folder contains a workspace file '{0}'. Do you want to open it? [Learn more]({1}) about workspace files.",
  workspaceFile,
  'https://go.microsoft.com/fwlink/?linkid=2025315'
) 

Note the use of ]( in the beginning of the Locked statement... this will programmatically force no space being injected.

[bpasero]

@TylerLeonhardt I was not aware. Its a bit odd having to use this directive though, can we automate it? We have a lot more usages that seem to be using a different hint:

E.g. Please ensure the markdown link syntax is not broken up with whitespace [text block](link block)

[TylerLeonhardt]

I don't have any good ideas for how to fix that at the moment... but at least we have an issue: #199829

[andreamah]

Not sure if this is because the translation hasn't gone through, but switching the language to french doesn't give me the french string here.

[TylerLeonhardt]

Looks like that string was not picked up. Unusual.

[TylerLeonhardt]

ok I think there was maybe a lag in translations as I see it now.