Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aux window: inactive tab fails to open from context menu #199799

Closed
stephenfrost opened this issue Dec 1, 2023 · 0 comments · Fixed by #199797
Closed

Aux window: inactive tab fails to open from context menu #199799

stephenfrost opened this issue Dec 1, 2023 · 0 comments · Fixed by #199797
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone
November 2023

Comments

@stephenfrost
Copy link

stephenfrost commented Dec 1, 2023 •
edited

Type: Bug

Per @bpasero, this is a new issue related to issue #198994. Currently in insiders, the tab with focus will be the one moved or copied into new window via context menu, even when I right-click on a different tab. I can understand the user NOT wanting right-click of non-focused tab to give it focus, but intuitively, it seems you'd want the context menu to act on the tab you right-clicked, regardless if the tab is the one with focus or not.

VS Code version: Code - Insiders 1.85.0-insider (7caa3f6, 2023-12-01T14:17:40.644Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz (12 x 2712)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.59GB (19.60GB free)
Process Argv --crash-reporter-id 91ea56c8-3aaf-40c5-a6d0-a59785153656
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
remote-containers ms- 0.326.0
remote-ssh ms- 0.107.1
remote-ssh-edit ms- 0.86.0
remote-wsl ms- 0.81.8
vscode-remote-extensionpack ms- 0.25.0
remote-explorer ms- 0.4.1
remote-server ms- 1.5.0
A/B Experiments 
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
a9j8j154:30646983
showlangstatbar:30737417
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
pythonmhint1:30901775
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30902439
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232
@bpasero bpasero self-assigned this Dec 1, 2023
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-auxwindow Issues related to use of auxiliary ("floating") windows. labels Dec 1, 2023
@bpasero bpasero added this to the December 2023 milestone Dec 1, 2023
@bpasero bpasero mentioned this issue Dec 1, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 1, 2023
@bpasero bpasero reopened this Dec 2, 2023
@bpasero bpasero modified the milestones: December 2023, November 2023 Dec 2, 2023
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Dec 2, 2023
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Dec 2, 2023
@bpasero bpasero changed the title no aux window via context menu for non-focused tabs (new issue from issue #198994) Aux window: inactive tab fails to open from context menu Dec 2, 2023
@bpasero bpasero mentioned this issue Dec 2, 2023
Merged
bpasero added a commit that referenced this issue Dec 4, 2023
@bpasero
aux window - fix action context for move/copy (fix #199799) (#199851)
df42214 
aux window - fix action context for move/copy
@bpasero bpasero closed this as completed Dec 4, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

aux window - fix action context for move/copy microsoft/vscode
4 participants
@bpasero @rzhao271 @stephenfrost @VSCodeTriageBot