Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI: throw or log error when vscode-remote without authority #199844

Closed
bpasero opened this issue Dec 2, 2023 · 0 comments · Fixed by #203594
Closed

URI: throw or log error when vscode-remote without authority #199844

bpasero opened this issue Dec 2, 2023 · 0 comments · Fixed by #203594
Assignees
@bpasero @jrieken
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues uri
Milestone
February 2024

Comments

@bpasero
Copy link
Member

bpasero commented Dec 2, 2023

Issue #199650 shows that bringing in vscode-remote URIs without authority is very dangerous. We should make sure this does not happen in the future, either by throwing or logging an error (I would prefer throwing).

Maybe we limit this to only a few places like showTextDocument / openTextDocument to being with?
@bpasero bpasero added the uri label Dec 2, 2023
@bpasero bpasero added this to the December 2023 milestone Dec 2, 2023
@bpasero bpasero mentioned this issue Dec 2, 2023
Closed
@bpasero bpasero added debt Code quality issues remote Remote system operations issues labels Dec 2, 2023
@bpasero bpasero modified the milestones: December / January 2024, February 2024 Jan 20, 2024
bpasero added a commit that referenced this issue Jan 27, 2024
@bpasero
ext host - log error when attempting to open/show a document of inval…
dc02245 
…id remote URI (#199844)
@bpasero bpasero mentioned this issue Jan 29, 2024
Merged
bpasero added a commit that referenced this issue Jan 29, 2024
@bpasero
ext host - log error when attempting to open/show a document of inval…
88f74b7 
…id remote URI (#199844) (#203594)

* ext host - log error when attempting to open/show a document of invalid remote URI (#199844)

* use `extHostApiDeprecation`
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues uri
Projects
None yet
Milestone
February 2024
3 participants
@bpasero @jrieken @VSCodeTriageBot