Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the new icon picker generally usable for other components and adopt in terminal #199964

Closed
4 tasks
Tyriar opened this issue Dec 4, 2023 · 4 comments · Fixed by #209118
Closed
4 tasks

Make the new icon picker generally usable for other components and adopt in terminal #199964

Tyriar opened this issue Dec 4, 2023 · 4 comments · Fixed by #209118
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes terminal-tabs user-profiles User profile management verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2023

Forked off from #188972 (comment) as that issue is closed.

Related: #171076

We currently have a blaring inconsistency in the UI with 2 separate icon pickers:

image

image

I consider this icon picker work still a work in progress and not completed because of this. To fix this, before the terminal adopts we need more icons in the picker (#171076) such that the regression in functionality in the terminal is not so severe. For example we must have icons debian, ubuntu, etc.

Breakdown of work:

@Tyriar Tyriar added feature-request Request for new features or functionality debt Code quality issues terminal-tabs user-profiles User profile management labels Dec 4, 2023
@Tyriar Tyriar added this to the On Deck milestone Dec 4, 2023
@sandy081
Copy link
Member

sandy081 commented Jan 8, 2024

@Tyriar

Icon Pickeris generic icon widget that can be reused by other components. In addition, a component can pass what icons to be displayed.

Can you please let me know what changes do you mean to implement in the widget?

@Tyriar
Copy link
Member Author

Tyriar commented Mar 29, 2024

Adopted in #209118, I deduped the icons and selected the first in the icon registry of any given fontCharacter.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 1, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Apr 22, 2024
@benibenj benibenj added the verified Verification succeeded label Apr 23, 2024
@gusbemacbe
Copy link

Good evening, @Tyriar!

Will we be able to choose our custom icons for user profile and terminal icon? For example, Codicons does not have brain, flower, paint roller icons, unlike Font Awesome has.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 24, 2024

@gusbemacbe yes I believe this is possible with this change, if icons from extensions aren't pulled in could you create an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes terminal-tabs user-profiles User profile management verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants