Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to symbol" looks like only take care of upper cases #20039

Closed
hansanghoon opened this issue Feb 6, 2017 · 3 comments
Closed

"Go to symbol" looks like only take care of upper cases #20039

hansanghoon opened this issue Feb 6, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@hansanghoon
Copy link

  • VSCode Version: Code 1.9.0 (27240e7, 2017-02-02T08:23:30.856Z)
  • OS Version: Darwin x64 16.4.0
  • Extensions:
Extension Author Version
beautify HookyQR 0.7.3
vscode-eslint dbaeumer 1.2.2
vscode-dash deerawan 1.3.0
bower donjayamanne 0.0.3
vscode-babel-coloring dzannotti 0.0.4
debugger-for-chrome msjsdiag 2.5.1
polymer-ide polymer 0.3.0
java redhat 0.0.9
elm sbrink 0.8.3
JavaScriptSnippets xabikos 1.2.0

Steps to Reproduce:

  1. create js file with content as below
function helloWorld1() {}
function hElloWorld2() {}
function helloWOrld3() {}
function hElloWOrld4() {}
  1. type eo in cmd+shift+o and cmd+t with case combinations
typed char @ #
eo image image
eO image image
Eo image image
EO image image

I only ran tests for a single file case, but something isn't right... only hElloWOrld4 got attention and even worse, Go to symbol in workspace sometimes shows no result.

@bpasero
Copy link
Member

bpasero commented Feb 6, 2017

@aeschli for if we do something bad in the open symbol filtering and @waderyan to see if this is a bug in TypeScript actually. I suspect the latter.

@aeschli
Copy link
Contributor

aeschli commented Feb 6, 2017

@bpasero That's a long time ago since I touched that code. I suggest @mjbvz and @waderyan have a look.

@aeschli aeschli removed their assignment Feb 6, 2017
@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Feb 6, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 6, 2017

The root cause is that workspace and document symbol search use different filtering logic.

For symbol search in a document, we take all symbols in the document and filter the results down on the VSCode side. For workspace symbol search, we send a search term to TypeScript who returns an already filtered list of results

I've opened microsoft/TypeScript#13909 to track fuzzier matches on the TypeScript side

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants