Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include reactor information in comment reaction information #201131

Open
alexr00 opened this issue Dec 18, 2023 · 0 comments
Open

Include reactor information in comment reaction information #201131

alexr00 opened this issue Dec 18, 2023 · 0 comments
Assignees
Labels
api api-proposal comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

Currently, the emoji reactions on the comments widget just shows the number of reactions, not any info about where those reactions came from:

image

On GitHub, for example, the reactions include the usernames of the reactors in hover text:
image

We could expand the comments reaction API to allow something similar by adding a reactors property to the CommentReaction:

	export interface CommentReaction {
		readonly reactors?: readonly string[];
	}

To show something like this:

image

@alexr00 alexr00 added feature-request Request for new features or functionality api api-proposal comments Comments Provider/Widget/Panel issues labels Dec 18, 2023
@alexr00 alexr00 added this to the December / January 2024 milestone Dec 18, 2023
@alexr00 alexr00 self-assigned this Dec 18, 2023
alexr00 added a commit that referenced this issue Dec 18, 2023
alexr00 added a commit that referenced this issue Dec 18, 2023
Add comment reactors proposal
Part of #201131
alexr00 added a commit that referenced this issue Jan 9, 2024
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Jan 9, 2024
@alexr00 alexr00 modified the milestones: December / January 2024, On Deck Jan 9, 2024
alexr00 added a commit that referenced this issue Jan 9, 2024
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api api-proposal comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

1 participant