Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable change settings from deactivate() function #201664

Open
vanowm opened this issue Jan 1, 2024 · 1 comment
Open

Unable change settings from deactivate() function #201664

vanowm opened this issue Jan 1, 2024 · 1 comment
Assignees

Comments

@vanowm
Copy link

vanowm commented Jan 1, 2024

Type: Bug

Attempting change global setting inside deactivate() function fail. No changes are done

Example:

export function deactivate() {
  const config = workspace.getConfiguration();
  console.log("deactivate()", "before", JSON.stringify(config.get('mysetting')));
  config.update('mysetting', Date.now(), true);
  console.log("deactivate()", "after", JSON.stringify(config.get('mysetting')));
}

The console shows before and after the same value undefined and global settings.json not changed

VS Code version: Code 1.85.1 (0ee08df, 2023-12-13T09:49:37.021Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 63.67GB (30.51GB free)
Process Argv --verbose
Screen Reader no
VM 50%
Extensions (87)
Extension Author (truncated) Version
better-comments aar 3.0.2
vscode-javascript-repl ach 0.7.4
vscode-userscript adp 1.3.2
Bookmarks ale 13.4.2
tsl-problem-matcher amo 0.6.2
vscode-scriptmonkey and 0.0.8
chronicler arc 0.1.16
autolispext Aut 1.6.2
vscode-log-viewer ber 0.14.1
github-markdown-preview bie 0.3.0
markdown-checkbox bie 0.4.0
markdown-emoji bie 0.3.0
markdown-footnotes bie 0.1.1
markdown-mermaid bie 1.21.0
markdown-preview-github-styles bie 2.0.3
markdown-yaml-preamble bie 0.1.0
vscode-intelephense-client bme 1.10.2
git-exclude bou 0.3.1
phpserver bra 3.0.2
insert-unicode bru 0.15.1
turbo-console-log Cha 2.9.10
ascii-table-fork Coo 1.1.0
jsdoc-generator cry 2.0.1
autoit Dam 1.0.12
vscode-eslint dba 2.4.2
xml Dot 2.5.1
gitlens eam 14.6.1
vscode-html-css ecm 2.0.1
EditorConfig Edi 0.16.4
vscode-great-icons emm 2.1.102
prettier-vscode esb 10.1.0
vscode-macros EXC 1.4.1
vscode-highlight fab 1.9.0
vscode-firefox-debug fir 2.9.10
auto-rename-tag for 0.1.10
copilot Git 1.143.601
copilot-chat Git 0.11.1
remotehub Git 0.62.0
vscode-pull-request-github Git 0.78.1
triggertaskonsave Gru 0.2.17
vscode-htmlhint HTM 1.0.5
reg ion 1.1.0
vscode-peacock joh 4.2.2
minifyall jos 2.10.0
node-module-intellisense lei 1.5.0
Lisp mat 0.1.12
render-crlf med 1.7.1
vscode-language-babel mgm 0.0.40
git-graph mhu 1.30.0
line-journey-undo MKM 0.0.1
vscode-filesize mkx 3.1.0
vscode-apache mrm 1.2.0
vscode-edge-devtools ms- 2.1.3
isort ms- 2023.10.1
python ms- 2023.22.1
vscode-pylance ms- 2023.12.1
hexeditor ms- 1.9.12
js-debug-nightly ms- 2023.12.1817
live-server ms- 0.4.13
remote-repositories ms- 0.40.0
test-adapter-converter ms- 0.1.8
color-highlight nau 2.5.0
vscode-auto-scroll pej 1.1.0
vscode-versionlens pfl 1.9.2
vscode-phpunit rec 3.2.2
vscode-xml red 0.26.1
format-html-in-php rif 1.7.0
vs-code-prettier-eslint rve 5.1.0
multi-command ryu 1.6.0
vbsvscode Ser 1.2.1
swapdiff sha 0.2.2
comment-divider sta 0.4.0
code-spell-checker str 3.0.1
vscode-stylelint sty 1.3.0
tabnine-vscode Tab 3.54.2007
tauri-vscode tau 0.2.6
pdf tom 1.2.2
vscode-ltex val 13.1.0
intellicode-api-usage-examples Vis 0.2.8
vscodeintellicode Vis 1.2.30
vscode-wakatime Wak 24.4.0
vscode-backup Wes 0.0.6
eno Wsc 2.3.53
php-debug xde 1.34.0
local-history xyz 1.8.1
json-color-token yec 1.3.3
html-css-class-completion Zig 1.20.0
@sandy081
Copy link
Member

sandy081 commented Jan 3, 2024

@alexdima I suspect this is not support during deactivation, hence assigning to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants