Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between status bar items of different ext hosts #201795

Open
CGNonofr opened this issue Jan 4, 2024 · 0 comments · May be fixed by #201796
Open

Conflict between status bar items of different ext hosts #201795

CGNonofr opened this issue Jan 4, 2024 · 0 comments · May be fixed by #201796
Assignees
Labels
debt Code quality issues extension-host Extension host issues workbench-status Status bar

Comments

@CGNonofr
Copy link
Contributor

CGNonofr commented Jan 4, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.85.1
  • OS Version: Ubuntu 22.04

When using the window.createStatusBarItem extension api, the id parameter is optional. If it's not provided, it's generated by incrementing a counter (see

this._entryId = String(ExtHostStatusBarEntry.ID_GEN++);
)

That counter is inside the extHost, so if 2 extensions running in a different extHost (like Worker and Remote) are using the window.createStatusBarItem extension api without providing an id, they will conflict and be merged into a single item leading to unexpected behaviors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues extension-host Extension host issues workbench-status Status bar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants