Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent conflict between status bar item ids #201796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Jan 4, 2024

fix #201795

instead of using a incremented id which can conflict between extHosts, use an uuid which will always be unique

@bpasero
Copy link
Member

bpasero commented Jan 10, 2024

We seem to be using 2 identifiers for the status bar entry, the one I added later was for allowing to show/hide entries and does not seem to be impacted by this change. The one that is impacted here however is a different identifier that was already there from before (entryId) and I am not entirely sure if that can just work with UUIDs, adding Jo to look at it as well.

@jrieken
Copy link
Member

jrieken commented Jan 10, 2024

instead of using a incremented id which can conflict between extHosts, use an uuid which will always be unique

This is an interesting find and there is something do but just using a UUID will introduce other bugs. The setStatusBarMessage-API uses a status bar item with incrementing id and for that it is actually wanted to be reused across EHs. All other items have an associated extension identifier so we might simply wanna use a default id

@bpasero bpasero removed their assignment Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict between status bar items of different ext hosts
5 participants