Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Increase Current View Size" and "Decrease Current View Size" when in zen mode #203334

Closed
Ozoniuss opened this issue Jan 24, 2024 · 5 comments
Labels
feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues

Comments

@Ozoniuss
Copy link

Type: Bug

Steps to reproduce:

  • Toggle Zen Mode;
  • Make sure there are no other open views except one single editor;
  • Trigger either Increase Current View Size or Decrease Current View Size command.

Please look at the attached video which goes through these steps interactively.

Expected Behaviour:

The open editor either expands or shrinks horizontally.

Current Behaviour:

Nothing happens :(

Context:

Vscode has two nice commands for increasing/decreasing the current view size, workbench.action.increaseViewSize and workbench.action.decreaseViewSize. I like to map these to shortcuts. They work as indended, except the scenario presented above.

The command works as expected if there are at least two open editors (read below for one open editor alongside additional panels).

My main use case for wanting to do this is working on some certain files (typically HTML) where I could use the extra length of the editor. I usually keep my code within 80 or 120 characters long or use word wrapping, but that looks awkward in those scenarios.

I think that it's not straightforward to define what the behaviour should be if a single editor is open, alongside with one or more different panels (not editors) such as the file explorer (usually on the right) or the terminal (usually below). At the moment the command does increase or decrease their size accordingly, and one could argue about whether or not it should also increase or decrease the editor size. Though, I don't have a problem with doing nothing when additional panels are open. My desire is using this command while only one single editor is open.

If this is indeed deemed as a bug, I am open to contributing a fix.

Additional Information

VS Code version: Code 1.85.2 (8b37750, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

|Item|Value|

|---|---|
|CPUs|AMD Ryzen 7 5800H with Radeon Graphics (16 x 3194)|
|GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled|
|Load (avg)|undefined|
|Memory (System)|31.86GB (14.47GB free)|
|Process Argv|casheer --crash-reporter-id be976544-dff3-4716-a7ac-f8062db9d610|
|Screen Reader|no|
|VM|0%|

Extensions: none

Screen Capture

viewsize.mp4
@sbatten
Copy link
Member

sbatten commented Jan 26, 2024

@bpasero looks like we have Inc/Dec View Size commands and Inc/Dec Editor Width commands. The View Size commands are targeting Parts and it sounds like the use case here is for the editor width in centered layout inside the editor part. Is this in my space or yours?

@bpasero
Copy link
Member

bpasero commented Jan 26, 2024

I can take it!

@bpasero bpasero added feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues labels Jan 26, 2024
@bpasero bpasero changed the title "Increase Current View Size" and "Decrease Current View Size" commands not working in Zen mode if only one single editor is open Allow "Increase Current View Size" and "Decrease Current View Size" when in zen mode Jan 26, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Jan 26, 2024
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality workbench-zen Full screen 'Zen' view issues
Projects
None yet
Development

No branches or pull requests

5 participants