"editor.formatOnSaveMode": "modifications" broken anywhere & "editor.formatOnSaveMode": "modificationsIfAvailable" relies on modification anyway

[Malix-off]

From Extension

Does this issue occur when all extensions (except the formatter's extension) are disabled?: Yes

Description

"editor.formatOnSaveMode": "modifications" is broken anywhere & "editor.formatOnSaveMode": "modificationsIfAvailable" relies on modification anyway
(Tested with Golang and TypeScript)

Version

• VS Code Version: 1.85.2 - 8b37750 - x64
• OS Version: Edition Windows 11 Home - Version 23H2 - 22635.3066

Steps to reproduce

1. Clone https://github.com/Malix-off/vscode-issues-203463
2. Disable every extension except golang.go.
3. Test with "editor.formatOnSaveMode": "file"
   1. Make https://github.com/Malix-off/vscode-issues-203463/blob/master/main.go unformatted (for exemple, add a tabulation before L3)
   2. Save
   3. Check results (currently works)
4. Test with "editor.formatOnSaveMode": "modifications"
   1. Make https://github.com/Malix-off/vscode-issues-203463/blob/master/main.go unformatted (for exemple, add a tabulation before L3)
   2. Save
   3. Check results (currently doesn't work)
5. Test with "editor.formatOnSaveMode": "modificationsIfAvailable"
   1. Make https://github.com/Malix-off/vscode-issues-203463/blob/master/main.go unformatted (for exemple, add a tabulation before L3)
   2. Save
   3. Check results (currently call "modifications", thus doesn't work)

[jrieken]

Screen.Recording.2024-01-26.at.09.17.21.mov

This works for me. Please clarify, esp the following is needed

• copy-paste friendly source code sample, please use TS because that ships with VS Code
• the name of the extension that provides formatting edits
• complete steps

[Malix-off]

Hello @jrieken !

I did succeed to reproduce the TypeScript problem, but it seems to be due to my skill issue about having conflits by having Biome, Prettier, and Eslint enabled at the same time, my bad.

However, I did reproduced the issue with Golang with golang.go.

Check updated #203463 (comment)

[VSCodeTriageBot]

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.

Happy Coding!

[jrieken]

However, I did reproduced the issue with Golang with golang.go.

This is good digging but please file an issue against the extension. VS Code doesn't actually compute or "fix up" edits from formatters. We merely send ranges that need formatting and we trust the extension's result

[Malix-off]

Okay, imma contact them then, thanks and have a great day!

[Malix-off]

See golang/vscode-go#3174