Inline chat holds on to untitled documents (part 2)

[jrieken]

this is a long-ish demo of a potential 🐛 that is still of happening:

• when the file becomes dirty (ie, copilot writes some code), closing out and dismissing the save will not increment the untitled names (what was mentioned in this issue).
• But when copilot doesn't write code, closing it out and using ctrl+n again for a new file opens a file with the name Untitled-2 (increments the untitled name)

Screen.Recording.2024-01-25.at.9.30.16.PM.mov

Originally posted by @justschen in #203448 (comment)

[jrieken]

@bpasero I need you input here. Today, I listen to untitled document becoming non-dirty but in this case it never was dirty. It feels like I am missing an event. Do I need use the events of editor tabs to see if no tab exists anymore?

[bpasero]

Lets talk when we are both in the office, there is something in the untitled land that I was planning to change in debt land that could be related.

The rule for incrementing the counter for untitled files is based on whether an untitled model still exists:

vscode/src/vs/workbench/services/untitled/common/untitledTextEditorService.ts

Lines 241 to 245 in feff7c8

	let counter = 1;
	do {
	untitledResource = URI.from({ scheme: Schemas.untitled, path: `Untitled-${counter}` });
	counter++;
	} while (this.mapResourceToModel.has(untitledResource));

So maybe someone still holds a reference to the untitled file and thus it does not get disposed. Remember that last milestone I had changed untitled models to be strictly disposable only when the last reference is disposed, even on revert.

[jrieken]

So maybe someone still holds a reference to the untitled file and thus it does not get disposed.

🙋 that's me and the culprit of this issue. Inline chat creates references to the models it uses. That's because when changing between editor tabs I need to hold on to things. This is also true for closing but when closing non-dirty untitled editor I want to release sessions (e.g stop preventing to dispose them)