Complete walkthrough steps with commands after command execution #203573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyaus
force-pushed
the
dev/bhavyau/walkthrough-completions
branch
from
0e0c1f7
to
96b61ea
Compare
rzhao271
approved these changes
Jan 26, 2024
rossdanlm
pushed a commit
to lastmile-ai/aiconfig
that referenced
this pull request
Feb 25, 2024
Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) ##Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573
rossdanlm
pushed a commit
to lastmile-ai/aiconfig
that referenced
this pull request
Feb 25, 2024
Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) https://github.com/lastmile-ai/aiconfig/assets/151060367/d9a74035-1951-4cf7-adbc-4c4b2bcad6c1 Trying on Jupyter notebooks walkthrough also doesn't work for me https://github.com/lastmile-ai/aiconfig/assets/151060367/39231e92-fe53-41bd-ac4a-cf94725975f5 ## Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573
rossdanlm
pushed a commit
to lastmile-ai/aiconfig
that referenced
this pull request
Feb 25, 2024
Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) https://github.com/lastmile-ai/aiconfig/assets/151060367/d9a74035-1951-4cf7-adbc-4c4b2bcad6c1 Trying on Jupyter notebooks walkthrough also doesn't work for me https://github.com/lastmile-ai/aiconfig/assets/151060367/39231e92-fe53-41bd-ac4a-cf94725975f5 ## Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573
rossdanlm
pushed a commit
to lastmile-ai/aiconfig
that referenced
this pull request
Feb 25, 2024
Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) https://github.com/lastmile-ai/aiconfig/assets/151060367/d9a74035-1951-4cf7-adbc-4c4b2bcad6c1 Trying on Jupyter notebooks walkthrough also doesn't work for me https://github.com/lastmile-ai/aiconfig/assets/151060367/39231e92-fe53-41bd-ac4a-cf94725975f5 ## Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573
rossdanlm
added a commit
to lastmile-ai/aiconfig
that referenced
this pull request
Feb 25, 2024
Add completion events to walkthrough steps Ok, upon further investigation, I found out that the `completionEvents` doesn't actually do anything anymore: microsoft/vscode#176074 (comment). However, this no-op is being reverted in next VS Code update in microsoft/vscode#176074 (comment), so it's still good to included this here!!! We should then advertise to people to pls update their VS Code version!!! You can read more about completion events in https://code.visualstudio.com/api/references/contribution-points#Completion-events ~~Now we shouldn't auto-mark steps as completed unless command has been run~~ I also added "CMD/CTRL" to the readme files and renamed the readme files to be non-capitalized. I also made some content changes in the walkthrough mardown because it was annoying me, but feel it's better and more precise. ## Test Plan This actually has no functional changes at all becuase of microsoft/vscode#176074 (comment) until users update the latest VS Code version (which I tried to do but still doesn't work for me :/ ) https://github.com/lastmile-ai/aiconfig/assets/151060367/d9a74035-1951-4cf7-adbc-4c4b2bcad6c1 Trying on Jupyter notebooks walkthrough also doesn't work for me https://github.com/lastmile-ai/aiconfig/assets/151060367/39231e92-fe53-41bd-ac4a-cf94725975f5 ## Appendix The timeline for this is pretty wild: 1. Someone doesn't like having checkboxes so removed the functionality in microsoft/vscode#166747 to automatically check once a step is viewed. The PR for addressing this was done in Jan 31, 2023: microsoft/vscode#172941 2. People complained about this, so microsoft/vscode#176074 was filed on March 3, 2023 3. Change for reverting back to original completionEvent feature was done in January 24, 2024: microsoft/vscode#203573 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1340). * #1346 * #1345 * #1343 * #1341 * __->__ #1340 * #1329
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously changed this behavior so that all steps would complete immediately after open. This was done to alleviate #166747
However, we noticed no significant changes in user behavior in walkthrough completions (from telemetry) and we still see drop-off after the first few steps.
We have also seen this: #176074 feedback from extension authors.