Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings search box clears while searching #203758

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: settings search box clears while searching #203758

merged 3 commits into from
Jan 31, 2024

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jan 30, 2024 •
edited

Fixes #200085

@rzhao271 rzhao271 self-assigned this Jan 30, 2024
@rzhao271 rzhao271 enabled auto-merge (squash) January 30, 2024 00:24
@rzhao271 rzhao271 added this to the February 2024 milestone Jan 30, 2024
@roblourens
Copy link
Member

Could you use this.searchInputDelayer.isTriggered instead of a new flag?

@rzhao271 rzhao271 merged commit 6d2c017 into main Jan 31, 2024
6 checks passed
@rzhao271 rzhao271 deleted the rzhao271/sympathetic-squid branch January 31, 2024 14:11
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.

Doing a search when the Settings editor first loads results in the query being cleared
2 participants
@rzhao271 @roblourens