Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings search box clears while searching #203758

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: settings search box clears while searching #203758

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
829bfd4
fix: settings search box clears while searching
rzhao271 Jan 30, 2024
f30e479
fix: use isTriggered instead of new variable
rzhao271 Jan 30, 2024
eee2b10
polish
rzhao271 Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,8 @@ export class SettingsEditor2 extends EditorPane {
this.searchWidget.setValue(filter);
}

this.searchWidget.focus(selectAll);
// Do not select all if the user is already searching.
this.searchWidget.focus(selectAll && !this.searchInputDelayer.isTriggered);
}

clearSearchResults(): void {
Expand Down