Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Autocomplete with Default Colour in Workspace Colour Customisations #203828

Closed
Number-3434 opened this issue Jan 30, 2024 · 5 comments
Closed

[BUG] Autocomplete with Default Colour in Workspace Colour Customisations #203828

Number-3434 opened this issue Jan 30, 2024 · 5 comments
Assignees
@aeschli

Comments

@Number-3434
Copy link

Number-3434 commented Jan 30, 2024 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

Provide autocompletions for properties in workbench.colorCustomizations with the default colours, instead of #ff0000.
@Number-3434 Number-3434 changed the title [BUG] Autocomplete for Workspace Colour Customisations [BUG] Autocomplete with Default Colour in Workspace Colour Customisations Jan 30, 2024
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2024

#25633 is similar. Ok to mark as duplicate?

@Number-3434
Copy link
Author

#25633 is similar. Ok to mark as duplicate?

Yes, sorry I didn't realize. Could you change the title of that to be a bit more concise?

@Number-3434 Number-3434 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2024

#25633 is about the current value (based on the currently selected theme) while your suggestion is about the default value (which is the color of the Default Modern theme).
I think the current color is more useful as you normally want to tune the currently visible colors.

@Number-3434
Copy link
Author

Number-3434 commented Jan 31, 2024 •
edited
Loading

#25633 is about the current value (based on the currently selected theme) while your suggestion is about the default value (which is the color of the Default Modern theme).
I think the current color is more useful as you normally want to tune the currently visible colors.

Yeah, sorry I meant the default colour for the currently selected theme.

@Number-3434
Copy link
Author

Would this be easy to implement?

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeschli @Number-3434