Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code comment for Unpublished extension flag in extensionGalleryService.ts #205003

Closed
xavierdecoster opened this issue Feb 12, 2024 · 0 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@xavierdecoster
Copy link
Contributor

xavierdecoster commented Feb 12, 2024

The comment associated with this code is incorrect:

	/**
	 * This flag switches the asset uri to use GetAssetByName instead of CDN
	 * When this is used, values of base asset uri and base asset uri fallback are switched
	 * When this is used, source of asset files are pointed to Gallery service always even if CDN is available
	 */
	Unpublished = 0x1000,

I suggest changing it to something like this:

	/**
	 * The Unpublished extension flag indicates that the extension can't be installed/downloaded.
	 * Users who have installed such an extension can continue to use the extension.
	 */
	Unpublished = 0x1000,
xavierdecoster added a commit to xavierdecoster/vscode that referenced this issue Feb 12, 2024
@sandy081 sandy081 self-assigned this Feb 12, 2024
@sandy081 sandy081 added the debt Code quality issues label Feb 12, 2024
@sandy081 sandy081 added this to the February 2024 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants