Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show contributed issues in quick access #206303

Merged
merged 12 commits into from Mar 7, 2024

Conversation

justschen
Copy link
Contributor

@justschen justschen commented Feb 26, 2024

ctrl + p -> issues

Screenshot 2024-03-04 at 5 22 08 PM

@justschen justschen marked this pull request as ready for review February 28, 2024 18:46
@VSCodeTriageBot VSCodeTriageBot added this to the March 2024 milestone Feb 28, 2024
Comment on lines +104 to +109
private _createPick(filter: string, action?: MenuItemAction | SubmenuItemAction | undefined, extension?: IRelaxedExtensionDescription): IPickerQuickAccessItem | undefined {
if (action && 'source' in action.item && action.item.source) {
const label = action.item.source?.title;
const highlights = matchesFuzzy(filter, label, true);
if (highlights) {
return {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking. I feel like this function could be 2 different functions for actions or extensions... or you if setting a couple variables instead and then return a common object:

const buttons = [{
	iconClass: ThemeIcon.asClassName(Codicon.info),
	tooltip: localize('contributedIssuePage', "Open Extension Page")
}];

let label: string;
let trigger: THE_TRIGGER_TYPE;
let accept: THE_ACCEPT_TYPE;
if (action ....) {
    label = action.item.source?.title;
    trigger = () => {
        this.commandService.executeCommand('extension.open', action.item.source.id);
        return TriggerAction.CLOSE_PICKER;
    };
    accept = () => action.run();
} else if (extension) {
    label = extension.displayName ?? extension.name;
    trigger = () => {
        this.commandService.executeCommand('extension.open', extension.identifier.value);
 	return TriggerAction.CLOSE_PICKER;
    };
    accept = () => this.commandService.executeCommand('workbench.action.openIssueReporter', extension.identifier.value);
} else {
    // could this ever happen?
    return undefined;
}

return {
    label,
    highlights: { label: matchesFuzzy(filter, label, true) },
    buttons,
    trigger,
    accept
};

@justschen justschen merged commit d6fb91c into microsoft:main Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants