New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show contributed issues in quick access #206303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justschen
commented
Feb 26, 2024
src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts
Outdated
Show resolved
Hide resolved
…ributed at bottom, add button to open extension page, add experimental setting
src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+104
to
+109
private _createPick(filter: string, action?: MenuItemAction | SubmenuItemAction | undefined, extension?: IRelaxedExtensionDescription): IPickerQuickAccessItem | undefined { | ||
if (action && 'source' in action.item && action.item.source) { | ||
const label = action.item.source?.title; | ||
const highlights = matchesFuzzy(filter, label, true); | ||
if (highlights) { | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking. I feel like this function could be 2 different functions for actions or extensions... or you if
setting a couple variables instead and then return a common object:
const buttons = [{
iconClass: ThemeIcon.asClassName(Codicon.info),
tooltip: localize('contributedIssuePage', "Open Extension Page")
}];
let label: string;
let trigger: THE_TRIGGER_TYPE;
let accept: THE_ACCEPT_TYPE;
if (action ....) {
label = action.item.source?.title;
trigger = () => {
this.commandService.executeCommand('extension.open', action.item.source.id);
return TriggerAction.CLOSE_PICKER;
};
accept = () => action.run();
} else if (extension) {
label = extension.displayName ?? extension.name;
trigger = () => {
this.commandService.executeCommand('extension.open', extension.identifier.value);
return TriggerAction.CLOSE_PICKER;
};
accept = () => this.commandService.executeCommand('workbench.action.openIssueReporter', extension.identifier.value);
} else {
// could this ever happen?
return undefined;
}
return {
label,
highlights: { label: matchesFuzzy(filter, label, true) },
buttons,
trigger,
accept
};
src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts
Outdated
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctrl + p
->issues