Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show contributed issues in quick access #206303

Merged
merged 12 commits into from
Mar 7, 2024
72 changes: 72 additions & 0 deletions src/vs/code/electron-sandbox/issue/issueQuickAccess.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { PickerQuickAccessProvider, IPickerQuickAccessItem, FastAndSlowPicks, Picks } from 'vs/platform/quickinput/browser/pickerQuickAccess';
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
import { IMenuService, MenuId, MenuItemAction, SubmenuItemAction } from 'vs/platform/actions/common/actions';
import { matchesFuzzy } from 'vs/base/common/filters';
import { IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput';
import { localize } from 'vs/nls';
import { ICommandService } from 'vs/platform/commands/common/commands';

export class IssueQuickAccess extends PickerQuickAccessProvider<IPickerQuickAccessItem> {

static PREFIX = 'issue ';

constructor(
@IMenuService private readonly menuService: IMenuService,
@IContextKeyService private readonly contextKeyService: IContextKeyService,
@ICommandService private readonly commandService: ICommandService
) {
super(IssueQuickAccess.PREFIX, { canAcceptInBackground: true });
}

protected override _getPicks(filter: string): Picks<IPickerQuickAccessItem> | FastAndSlowPicks<IPickerQuickAccessItem> | Promise<Picks<IPickerQuickAccessItem> | FastAndSlowPicks<IPickerQuickAccessItem>> | null {

const issuePicks: Array<IPickerQuickAccessItem | IQuickPickSeparator> = [];

// creates menu from contributed
const menu = this.menuService.createMenu(MenuId.IssueReporter, this.contextKeyService);

// render menu and dispose
const actions = menu.getActions({ renderShortTitle: true }).flatMap(entry => entry[1]);
actions.forEach(action => {
const pick = this._createPick(action, filter);
if (pick) {
issuePicks.push(pick);
}
});

if (issuePicks.length > 0) {
issuePicks.push({ type: 'separator' });
}

const createTerminalLabel = localize("workbench.action.openIssueReporter", "Open Issue Reporter");
issuePicks.push({
label: `$(plus) ${createTerminalLabel}`,
ariaLabel: createTerminalLabel,
accept: () => this.commandService.executeCommand('workbench.action.openIssueReporter')
});
return issuePicks;
}

private _createPick(action: MenuItemAction | SubmenuItemAction, filter: string): IPickerQuickAccessItem | undefined {
if (action.item && 'source' in action.item && action.item.source?.title) {
const label = action.item.source?.title;
const highlights = matchesFuzzy(filter, label, true);
if (highlights) {
return {
label,
highlights: { label: highlights },
accept: (keyMod, event) => {
action.run();
}
};
}
}
return undefined;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ import { IDialogService } from 'vs/platform/dialogs/common/dialogs';
import { INativeHostService } from 'vs/platform/native/common/native';
import { IProgressService, ProgressLocation } from 'vs/platform/progress/common/progress';
import { IIssueMainService, IssueType } from 'vs/platform/issue/common/issue';
// eslint-disable-next-line local/code-import-patterns
justschen marked this conversation as resolved.
Show resolved Hide resolved
import { IssueQuickAccess } from 'vs/code/electron-sandbox/issue/issueQuickAccess';
import { IQuickAccessRegistry, Extensions as QuickAccessExtensions } from 'vs/platform/quickinput/common/quickAccess';

//#region Issue Contribution

Expand Down Expand Up @@ -134,4 +137,16 @@ CommandsRegistry.registerCommand('_issues.getSystemStatus', (accessor) => {
return accessor.get(IIssueMainService).getSystemStatus();
});

// Register quick access for contributed issues
Registry.as<IQuickAccessRegistry>(QuickAccessExtensions.Quickaccess).registerQuickAccessProvider({
justschen marked this conversation as resolved.
Show resolved Hide resolved
ctor: IssueQuickAccess,
prefix: IssueQuickAccess.PREFIX,
contextKey: 'inReportIssuePicker',
placeholder: localize('tasksQuickAccessPlaceholder', "Type the name of an extension to report on."),
helpEntries: [{
description: localize('startDebuggingHelp', "Open Issue Reporter"),
commandId: 'workbench.action.openIssueReporter',
commandCenterOrder: 50
}]
});
//#endregion