Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to reuse the inline chat widget for terminal and notebook cell generate #206940

Closed
5 tasks done
jrieken opened this issue Mar 6, 2024 · 0 comments
Closed
5 tasks done

Make it easier to reuse the inline chat widget for terminal and notebook cell generate #206940

jrieken opened this issue Mar 6, 2024 · 0 comments
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. inline-chat
Milestone
March 2024

Comments

@jrieken
Copy link
Member

jrieken commented Mar 6, 2024 •
edited

We have a few additions that allow for inline chat interaction, namely in terminals and inside notebooks to generate new cells. Tho, to make reuse of the widget there is some work that needs to be done

  • Customize primary actions
  • Parent editor -> provide editor configuration
  • Pull diff editor stuff out (pull into specific part)
  • CSS prefixing @meganrogge @Tyriar
  • Allow editoring of editors in output
@jrieken jrieken self-assigned this Mar 6, 2024
@jrieken jrieken added this to the March 2024 milestone Mar 6, 2024
@jrieken jrieken added engineering VS Code - Build / issue tracking / etc. inline-chat labels Mar 6, 2024
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
make status menu configurable
033e989 
#206940
@jrieken jrieken mentioned this issue Mar 6, 2024
Merged
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
Inline chat widget tweaks (#206954)
9626fb0 
* make status menu configurable

#206940

* pull inline chat zone widget into its own file

* 💄

* remove expand/crop feature

* make chat message contents scrollable
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
inline - change the input editor to be a normal editor, not an embedd…
ebf8f1f 
…ed one

#206940
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
relayout when zone widget width changes (#206963)
b92a5dd 
* inline - change the input editor to be a normal editor, not an embedded one

#206940

* relayout when zone widget width changes
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
Have InlineChatWidget and EditorBasedInlineChatWidget so that the…
d638fec 
… former can be reuse outside of an editor context

#206940
@jrieken jrieken mentioned this issue Mar 6, 2024
Merged
jrieken added a commit that referenced this issue Mar 6, 2024
@jrieken
Have InlineChatWidget and EditorBasedInlineChatWidget so that the…
b37060a 
… former can be reuse outside of an editor context (#206986)

#206940
@jrieken jrieken closed this as completed Mar 13, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. inline-chat
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
1 participant
@jrieken