Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: V can be wrongly rescaled #208102

Closed
Tyriar opened this issue Mar 19, 2024 · 4 comments · Fixed by #208244
Closed

Terminal: V can be wrongly rescaled #208102

Tyriar opened this issue Mar 19, 2024 · 4 comments · Fixed by #208244
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
March 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 19, 2024

Found by @amunger

image

image

dpr = 1

"editor.fontFamily": "Consolas, 'Courier New', monospace",
"terminal.integrated.fontSize": 14,
@Tyriar Tyriar added this to the March 2024 milestone Mar 19, 2024
@Tyriar Tyriar self-assigned this Mar 19, 2024
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 19, 2024
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 19, 2024
@Tyriar
Only scale when over 50% of following cell
f8ae7ed 
See microsoft/vscode#208102
@Tyriar Tyriar mentioned this issue Mar 19, 2024
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Mar 19, 2024

Upstream fix: xtermjs/xterm.js#5012

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Mar 19, 2024
@amunger
Copy link
Contributor

amunger commented Mar 19, 2024

the auto-complete font has issues with more characters as well.
image

@amunger
Copy link
Contributor

amunger commented Mar 20, 2024

normal text looks better but that completion font still has issues. I think that just comes from pwsh 7

@Tyriar
Copy link
Member Author

Tyriar commented Mar 20, 2024

I didn't end up pulling in the updated dep. Today I'll change it to never rescale ascii and then update so this problem will definitely go away even for italics.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 20, 2024
@Tyriar
Don't rescale ascii
4c90009 
See microsoft/vscode#208102
@Tyriar Tyriar mentioned this issue Mar 20, 2024
Merged
Tyriar added a commit that referenced this issue Mar 20, 2024
@Tyriar
Update xterm.js
26a111b 
Fixes #208102
@Tyriar Tyriar mentioned this issue Mar 20, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 21, 2024
@amunger amunger added the verified Verification succeeded label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

Update xterm.js microsoft/vscode
3 participants
@amunger @Tyriar @VSCodeTriageBot