Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Editor support sash on both sides of the gutter #208220

Closed
benibenj opened this issue Mar 20, 2024 · 3 comments · Fixed by #212088
Closed

Diff Editor support sash on both sides of the gutter #208220

benibenj opened this issue Mar 20, 2024 · 3 comments · Fixed by #212088
Assignees
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team
Milestone

Comments

@benibenj
Copy link
Contributor

The border on the left side of the gutter looks like a sash which makes me want to resize the diff view from there however it does not work. Would be great to be able to resize the split view from the left side as well.

Code_-_Insiders_Ya1MvlG7xR

// cc @joaomoreno

@bpasero bpasero added the papercut 🩸 A particularly annoying issue impacting someone on the team label Mar 20, 2024
@bpasero
Copy link
Member

bpasero commented Mar 20, 2024

Yes, 💯 , I was about to file the exact same issue 👍

@bpasero
Copy link
Member

bpasero commented Mar 20, 2024

Alternatively, I wonder if we should go back to a design where the shadow only appears where you can resize. Now it seems we added a second shadow, not sure what it adds though. It looks visually nice, but misleads me into thinking I can resize there.

@hediet hediet added feature-request Request for new features or functionality diff-editor Diff editor mode issues labels Mar 21, 2024
@hediet hediet added this to the March 2024 milestone Mar 21, 2024
@rebornix
Copy link
Member

Ran into this in non-default themes and it looks like UI glitches. Hope we can lower the shadow opacity.

@hediet hediet modified the milestones: March 2024, April 2024 Mar 26, 2024
@hediet hediet modified the milestones: April 2024, May 2024 Apr 25, 2024
hediet added a commit that referenced this issue May 6, 2024
@hediet hediet mentioned this issue May 6, 2024
hediet added a commit that referenced this issue May 6, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants