Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Chat Widget: /explain response is empty #208574

Closed
benibenj opened this issue Mar 25, 2024 · 3 comments
Closed

Inline Chat Widget: /explain response is empty #208574

benibenj opened this issue Mar 25, 2024 · 3 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
March 2024

Comments

@benibenj
Copy link
Contributor

Testing #208414

I find it weird that there is no response in the inline chat widget when running /explain. Maybe it could show something like Responded in panel and/or view explanation which when pressed reveals the response in the panel...

image
@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

It's a bit weird but when having /explain the response should be shown inside the chat panel

@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

fyi @joyceerhl

@jrieken jrieken added this to the March 2024 milestone Mar 25, 2024
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Mar 26, 2024
@jrieken
Copy link
Member

jrieken commented Mar 26, 2024

Pushing a fix to refer /explain to panel chat only when it is the only request in the conversation

jrieken added a commit that referenced this issue Mar 26, 2024
@jrieken
only honor refer flag when its command is the first and only
78faf01 
fixes #208574
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 26, 2024
@Tyriar Tyriar added the verified Verification succeeded label Mar 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
5 participants
@jrieken @Tyriar @benibenj @VSCodeTriageBot and others