Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline chat with multiple changes shifts focus and cursor to a suggestion on another line when invoked for multi line changes #208595

Open
bhavyaus opened this issue Mar 25, 2024 · 4 comments
Assignees
Milestone

Comments

@bhavyaus
Copy link
Contributor

bhavyaus commented Mar 25, 2024

Found when testing #208409

Copied repro steps from above TPI.

  1. enable inlineChat.acceptedOrDiscardBeforeSave (should be on by default)
  2. trigger inline chat again, get to make multiple changes (e.g ask it to use the assert-lib to check that some variable is a number)
  3. Observe that the suggestions shifts focus away from the active line if the first code suggestion is NOT at the current line in the editor. See below gif for repro.

Recording 2024-03-25 at 21 36 54

As a user, this experience is jarring. We should instead present the user with changes at the current line (if any) and then provide the option to shift focus away from the current line.

@jrieken jrieken added info-needed Issue requires more information from poster and removed info-needed Issue requires more information from poster labels Mar 25, 2024
@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

Please add steps and a complete sample. This isn't about focus about positions and revealing them. Inline chat tries to reveal the best matching location (from where you are)

@bhavyaus bhavyaus changed the title Inline chat with multiple changes shifts focus from where it was on the editor when invoked for multi line changes Inline chat with multiple changes shifts focus and cursor to a suggestion on another line when invoked for multi line changes Mar 25, 2024
@bhavyaus
Copy link
Contributor Author

bhavyaus commented Mar 25, 2024

Updated description with repro steps. Not an issue with the feature being tested in the TPI but still related to the inline chat experience.

@jrieken jrieken added inline-chat and removed info-needed Issue requires more information from poster labels Mar 25, 2024
@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

As a user, this experience is jarring. We should instead present the user with changes at the current line (if any) and then provide the option to shift focus away from the current line.

Agree - that's how it should work

@jrieken jrieken modified the milestones: March 2024, April 2024 Mar 25, 2024
@jrieken
Copy link
Member

jrieken commented Mar 27, 2024

Moving to April, I don't believe the is a regression and time is running out

@jrieken jrieken modified the milestones: April 2024, May 2024 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants