Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test inline chat review instructions #208409

Closed
2 tasks done
jrieken opened this issue Mar 22, 2024 · 0 comments
Closed
2 tasks done

Test inline chat review instructions #208409

jrieken opened this issue Mar 22, 2024 · 0 comments

Comments

@jrieken
Copy link
Member

jrieken commented Mar 22, 2024

Refs: #206939

Complexity: 2

Create Issue


We have improved the wording and UI around the signal that inline chat changes need to be reviews (accepted or discarded). Test that

  • enable inlineChat.acceptedOrDiscardBeforeSave (should be on by default)
  • trigger inline chat changes
  • read, understand, and judge the info message in the RHS
  • trigger inline chat again, get to make multiple changes (e.g ask it to use the assert-lib to check that some variable is a number)
  • check the message again and ensure it mentions all changes and updates as you accept/discard them
  • disable the inlineChat.acceptedOrDiscardBeforeSave and make sure the message just says 1 change etc
@jrieken jrieken added this to the March 2024 milestone Mar 22, 2024
@bhavyaus bhavyaus removed their assignment Mar 25, 2024
@dbaeumer dbaeumer removed their assignment Mar 25, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants